From: Javi Merino <javi.merino@cloud.com>
To: xen-devel@lists.xenproject.org
Cc: "Javi Merino" <javi.merino@cloud.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Juergen Gross" <jgross@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: [XEN PATCH v3 0/3] libxl: Fixes for libxl_xenconsole_readline()
Date: Mon, 2 Sep 2024 17:38:36 +0100 [thread overview]
Message-ID: <cover.1725294334.git.javi.merino@cloud.com> (raw)
Fix nul-termination of the return value of
libxl_xen_console_read_line(). While at it, remove unneeded memset()s
to the buffer and improve the documentation of the function.
Changes since v2[0]:
- Fixed comment format as suggested by Anthony
- Clarified that 16384 is the default size of xen's console buffer.
- Fixed `libxl_xen_console_read_line()` documentation as suggested by Alejandro and Andrew.
- line_r -> buff in `tools/include/libxl.h` as well.
Changes since v1[1]:
- Add Fixes: line to the first patch
- Remove cr->count from the struct and make it a local variable in
libxl_xen_console_read_line()
- Improve the documentation of libxl_xen_console_read_line()
[0] https://lore.kernel.org/xen-devel/cover.1724430173.git.javi.merino@cloud.com/
[1] https://lore.kernel.org/xen-devel/ad7c89bbae34155566ae7c9ca2cb501f21c7d585.1724330921.git.javi.merino@cloud.com/
Javi Merino (3):
libxl: Fix nul-termination of the return value of
libxl_xen_console_read_line()
libxl: Remove unnecessary buffer zeroing and zalloc()
libxl: Update the documentation of libxl_xen_console_read_line()
tools/include/libxl.h | 2 +-
tools/libs/light/libxl_console.c | 52 +++++++++++++++++++++----------
tools/libs/light/libxl_internal.h | 1 -
3 files changed, 36 insertions(+), 19 deletions(-)
--
2.45.2
next reply other threads:[~2024-09-02 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 16:38 Javi Merino [this message]
2024-09-02 16:38 ` [XEN PATCH v3 1/3] libxl: Fix nul-termination of the return value of libxl_xen_console_read_line() Javi Merino
2024-09-03 6:14 ` Jan Beulich
2024-09-02 16:38 ` [XEN PATCH v3 2/3] libxl: Remove unnecessary buffer zeroing and zalloc() Javi Merino
2024-09-03 8:23 ` Anthony PERARD
2024-09-02 16:38 ` [XEN PATCH v3 3/3] libxl: Update the documentation of libxl_xen_console_read_line() Javi Merino
2024-09-03 8:32 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1725294334.git.javi.merino@cloud.com \
--to=javi.merino@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.