From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 0/4] drm/i915/pps: hide VLV/CHV PPS pipe stuff inside intel_pps.c
Date: Wed, 4 Sep 2024 17:02:30 +0300 [thread overview]
Message-ID: <cover.1725458428.git.jani.nikula@intel.com> (raw)
It's bugged me for a long time that we poke the intel_pps->pps members
directly in a number of places, especially around VLV/CHV PPS pipe
handling. Hide it all inside intel_pps.c. The function naming may be a
bit contrived, but IMO better than the status quo.
BR,
Jani.
Jani Nikula (4):
drm/i915/pps: add intel_pps_dp_init() for all DP init
drm/i915/pps: move active_pipe set to intel_pps_dp_encoder_reset()
drm/i915/pps: add intel_pps_dp_power_down()
drm/i915/pps: add intel_pps_backlight_initial_pipe()
drivers/gpu/drm/i915/display/g4x_dp.c | 19 +------
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_dp.c | 23 ++-------
drivers/gpu/drm/i915/display/intel_pps.c | 63 +++++++++++++++++++++++-
drivers/gpu/drm/i915/display/intel_pps.h | 6 ++-
5 files changed, 73 insertions(+), 40 deletions(-)
--
2.39.2
next reply other threads:[~2024-09-04 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 14:02 Jani Nikula [this message]
2024-09-04 14:02 ` [PATCH 1/4] drm/i915/pps: add intel_pps_dp_init() for all DP init Jani Nikula
2024-09-04 14:02 ` [PATCH 2/4] drm/i915/pps: move active_pipe set to intel_pps_dp_encoder_reset() Jani Nikula
2024-09-04 14:02 ` [PATCH 3/4] drm/i915/pps: add intel_pps_dp_power_down() Jani Nikula
2024-09-04 15:53 ` Ville Syrjälä
2024-09-09 12:20 ` Jani Nikula
2024-09-04 14:02 ` [PATCH 4/4] drm/i915/pps: add intel_pps_backlight_initial_pipe() Jani Nikula
2024-09-04 15:19 ` ✗ Fi.CI.BAT: failure for drm/i915/pps: hide VLV/CHV PPS pipe stuff inside intel_pps.c Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1725458428.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.