From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
Johannes Berg <johannes@sipsolutions.net>,
David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-hardening@vger.kernel.org, Kees Cook <kees@kernel.org>
Subject: [PATCH v2 0/4][next] net: Avoid thousands of -Wflex-array-member-not-at-end warnings
Date: Thu, 24 Oct 2024 15:07:27 -0600 [thread overview]
Message-ID: <cover.1729802213.git.gustavoars@kernel.org> (raw)
This series aims to resolve thousands of -Wflex-array-member-not-at-end
warnings by introducing `struct sockaddr_legacy`. The intention is to use
it to replace the type of several struct members in the middle of composite
structures, currently of type `struct sockaddr`.
These middle struct members are currently causing thousands of warnings
because `struct sockaddr` contains a flexible-array member, introduced
by commit b5f0de6df6dce ("net: dev: Convert sa_data to flexible array in
struct sockaddR").
The new `struct sockaddr_legacy` doesn't include a flexible-array
member, making it suitable for use as the type of middle members
in composite structs that don't really require the flexible-array
member in `struct sockaddr`, thus avoiding -Wflex-array-member-not-at-end
warnings.
As this new struct will live in UAPI, to avoid breaking user-space code
that expects `struct sockaddr`, the `__kernel_sockaddr_legacy` macro is
introduced. This macro allows us to use either `struct sockaddr` or
`struct sockaddr_legacy` depending on the context in which the code is
used: kernel-space or user-space.
Changes in v2
- Drop nfsd patch.
- Move `struct sockaddr_legacy` to include/uapi/linux/socket.h
- Introduce `__kernel_sockaddr_legacy` macro (Kees)
v1:
Link: https://lore.kernel.org/linux-hardening/cover.1729037131.git.gustavoars@kernel.org/
Gustavo A. R. Silva (4):
uapi: socket: Introduce struct sockaddr_legacy
uapi: wireless: Avoid -Wflex-array-member-not-at-end warnings
uapi: net: arp: Avoid -Wflex-array-member-not-at-end warnings
uapi: net: Avoid -Wflex-array-member-not-at-end warnings
include/net/compat.h | 30 +++++++++----------
include/uapi/linux/if_arp.h | 18 +++++------
include/uapi/linux/route.h | 28 +++++++++---------
include/uapi/linux/socket.h | 28 ++++++++++++++++++
include/uapi/linux/wireless.h | 56 +++++++++++++++++------------------
net/appletalk/ddp.c | 2 +-
net/ipv4/af_inet.c | 2 +-
net/ipv4/arp.c | 2 +-
net/ipv4/fib_frontend.c | 2 +-
9 files changed, 98 insertions(+), 70 deletions(-)
--
2.34.1
next reply other threads:[~2024-10-24 21:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 21:07 Gustavo A. R. Silva [this message]
2024-10-24 21:11 ` [PATCH v2 1/4][next] uapi: socket: Introduce struct sockaddr_legacy Gustavo A. R. Silva
2024-10-28 20:38 ` Andrew Lunn
2024-10-28 20:47 ` Johannes Berg
2024-10-28 23:40 ` Kees Cook
2024-10-28 23:31 ` Kees Cook
2024-10-28 23:34 ` Kees Cook
2024-11-01 1:01 ` Jakub Kicinski
2024-11-04 3:43 ` Kees Cook
2024-10-24 21:12 ` [PATCH v2 2/4][next] uapi: wireless: Avoid -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2024-10-28 23:35 ` Kees Cook
2024-10-24 21:13 ` [PATCH v2 3/4][next] uapi: net: arp: " Gustavo A. R. Silva
2024-10-28 23:35 ` Kees Cook
2024-10-24 21:14 ` [PATCH v2 4/4][next] uapi: net: " Gustavo A. R. Silva
2024-10-28 23:37 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1729802213.git.gustavoars@kernel.org \
--to=gustavoars@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.