From: Viktor Malik <vmalik@redhat.com>
To: bpf@vger.kernel.org
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Viktor Malik <vmalik@redhat.com>
Subject: [PATCH bpf-next v3 0/3] selftests/bpf: Improve building with extra
Date: Fri, 1 Nov 2024 09:27:10 +0100 [thread overview]
Message-ID: <cover.1730449390.git.vmalik@redhat.com> (raw)
When trying to build BPF selftests with additional compiler and linker
flags, we're running into multiple problems. This series addresses all
of them:
- CFLAGS are not passed to sub-makes of bpftool and libbpf. This is a
problem when compiling with PIE as libbpf.a ends up being non-PIE and
cannot be linked with other binaries (patch #1).
- bpftool Makefile runs `llvm-config --cflags` and appends the result to
CFLAGS. The result typically contains `-D_GNU_SOURCE` which may be
already set in CFLAGS. That causes a compilation error (patch #2).
- Some GCC flags are not supported by Clang but there are binaries which
are always built with Clang but reuse user-defined CFLAGS. When CFLAGS
contain such flags, compilation fails (patch #3).
Changelog:
----------
v2 -> v3:
- resolve conflicts between patch #1 and 4192bb294f80 ("selftests/bpf:
Provide a generic [un]load_module helper")
- add Quentin's and Jiri's acks for patches #2 and #3
v1 -> v2:
- cover forgotten case in patch#1 (noted by Eduard)
- remove -D_GNU_SOURCE unconditionally in patch#2 (suggested by Andrii)
- rewrite patch#3 to just add -Wno-unused-command-line-argument
(suggested by Andrii)
Viktor Malik (3):
selftests/bpf: Allow building with extra flags
bpftool: Prevent setting duplicate _GNU_SOURCE in Makefile
selftests/bpf: Disable warnings on unused flags for Clang builds
tools/bpf/bpftool/Makefile | 6 ++++-
tools/testing/selftests/bpf/Makefile | 36 +++++++++++++++++++---------
2 files changed, 30 insertions(+), 12 deletions(-)
--
2.47.0
next reply other threads:[~2024-11-01 8:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 8:27 Viktor Malik [this message]
2024-11-01 8:27 ` [PATCH bpf-next v3 1/3] selftests/bpf: Allow building with extra flags Viktor Malik
2024-11-01 19:34 ` Andrii Nakryiko
2024-11-04 13:43 ` Toke Høiland-Jørgensen
2024-11-06 20:37 ` Andrii Nakryiko
2024-11-04 14:03 ` Toke Høiland-Jørgensen
2024-11-01 8:27 ` [PATCH bpf-next v3 2/3] bpftool: Prevent setting duplicate _GNU_SOURCE in Makefile Viktor Malik
2024-11-04 14:05 ` Toke Høiland-Jørgensen
2024-11-01 8:27 ` [PATCH bpf-next v3 3/3] selftests/bpf: Disable warnings on unused flags for Clang builds Viktor Malik
2024-11-01 19:46 ` [PATCH bpf-next v3 0/3] selftests/bpf: Improve building with extra Andrii Nakryiko
2024-11-04 11:34 ` Viktor Malik
2024-11-01 19:50 ` patchwork-bot+netdevbpf
2024-11-06 20:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1730449390.git.vmalik@redhat.com \
--to=vmalik@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=morbo@google.com \
--cc=mykolal@fb.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.