From: "Geoffrey D. Bennett" <g@b4.vu>
To: Takashi Iwai <tiwai@suse.de>
Cc: Takashi Iwai <tiwai@suse.com>, linux-sound@vger.kernel.org
Subject: [PATCH v3 0/2] ALSA: Add driver for big Scarlett 4th Gen interfaces
Date: Fri, 3 Jan 2025 09:08:07 +1030 [thread overview]
Message-ID: <cover.1735855597.git.g@b4.vu> (raw)
Hi Takashi,
Static buffers in the ioctl structs didn't seem to be the right way to
go, so I followed the instructions in
Documentation/drivers-api/ioctl.rst and the ioctls now work with
32-bit userspace on 64-bit kernels.
I added suspend/resume handling and all the suspend/resume cases that
I tried now work too.
Regards,
Geoffrey.
---
Changes in v3:
- Update ioctl structs and add ioctl_compat op to work with 32-bit
userspace on 64-bit kernels
- Update driver to do all init steps so it can re-init after
suspend/resume
- Add version field to init ioctl for future compatibility
- Improve error messages when unexpected response data is received
---
Changes in v2 as per Takashi's feedback:
- Use fixed-size data arrays instead of pointers in ioctl structs
- Define notify struct outside of struct fcp_dev
- Use u8/u16 types without __ prefix
- Use cleanup.h for code simplification
- Add init flag to ensure FCP_IOCTL_INIT is called before
FCP_IOCTL_CMD and FCP_IOCTL_SET_METER_MAP
- Do not destroy/recreate the meter control (the number of channels is
now fixed when it is created)
Geoffrey D. Bennett (2):
ALSA: FCP: Add Focusrite Control Protocol driver
ALSA: scarlett2: Add device_setup option to use FCP driver
MAINTAINERS | 10 +-
include/uapi/sound/fcp.h | 71 +++
sound/usb/Makefile | 1 +
sound/usb/fcp.c | 979 ++++++++++++++++++++++++++++++++++++
sound/usb/fcp.h | 7 +
sound/usb/mixer_quirks.c | 7 +
sound/usb/mixer_scarlett2.c | 8 +
7 files changed, 1079 insertions(+), 4 deletions(-)
create mode 100644 include/uapi/sound/fcp.h
create mode 100644 sound/usb/fcp.c
create mode 100644 sound/usb/fcp.h
--
2.45.0
next reply other threads:[~2025-01-02 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 22:38 Geoffrey D. Bennett [this message]
2025-01-02 22:38 ` [PATCH v3 1/2] ALSA: FCP: Add Focusrite Control Protocol driver Geoffrey D. Bennett
2025-01-02 22:38 ` [PATCH v3 2/2] ALSA: scarlett2: Add device_setup option to use FCP driver Geoffrey D. Bennett
2025-01-03 17:07 ` [PATCH v3 0/2] ALSA: Add driver for big Scarlett 4th Gen interfaces Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1735855597.git.g@b4.vu \
--to=g@b4.vu \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.