From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>
Cc: Vladimir Serbinenko <phcoder@gmail.com>,
Glenn Washburn <development@efficientek.com>
Subject: [PATCH v4 0/6] More ls improvements
Date: Mon, 6 Jan 2025 01:02:38 -0600 [thread overview]
Message-ID: <cover.1736132547.git.development@efficientek.com> (raw)
Considering Daniel's feedback on the v2 of this patch series, I've broken up
patches #1 and #2 and dropped patch #3 from the original series. These changes
make the output of the ls command a little more like the GNU ls output.
Glenn Washburn
v4: Add missing parenthesis
Glenn Washburn (6):
commands/ls: Return proper GRUB_ERR_* for functions returning type
grub_err_t
commands/ls: Merge print_files_long and print_files into print_file
commands/ls: Show modification time for file paths
commands/ls: Output path for single file arguments given with path
commands/ls: Print full paths for file args
commands/ls: Add directory header for dir args
grub-core/commands/ls.c | 93 ++++++++++++++++++++---------------------
1 file changed, 46 insertions(+), 47 deletions(-)
Range-diff against v3:
1: 9086cccd8a0f = 1: 9086cccd8a0f commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t
2: 3192dc2471d0 = 2: 3192dc2471d0 commands/ls: Merge print_files_long and print_files into print_file
3: fa7adbeee4e0 ! 3: 889e1e05a355 commands/ls: Show modification time for file paths
@@ grub-core/commands/ls.c: print_file (const char *filename, const struct grub_dir
if ((! ctx->all) && (filename[0] == '.'))
return 0;
-+ if (ctx->filename != NULL) && (grub_strcmp (filename, ctx->filename) != 0)
++ if ((ctx->filename != NULL) && (grub_strcmp (filename, ctx->filename) != 0))
+ return 0;
+
if (! ctx->longlist)
4: 5a1618235b6e = 4: d63e007f635b commands/ls: Output path for single file arguments given with path
5: 026f37b35adb = 5: 39adcb21e320 commands/ls: Print full paths for file args
6: 5bf39d658422 ! 6: 0ebbfd3b0e15 commands/ls: Add directory header for dir args
@@ grub-core/commands/ls.c: struct grub_ls_list_files_ctx
/* Helper for grub_ls_list_files. */
@@ grub-core/commands/ls.c: print_file (const char *filename, const struct grub_dirhook_info *info,
- if (ctx->filename != NULL) && (grub_strcmp (filename, ctx->filename) != 0)
+ if ((ctx->filename != NULL) && (grub_strcmp (filename, ctx->filename) != 0))
return 0;
+ if (ctx->print_dirhdr)
--
2.34.1
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next reply other threads:[~2025-01-06 7:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 7:02 Glenn Washburn [this message]
2025-01-06 7:02 ` [PATCH v4 1/6] commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t Glenn Washburn
2025-01-06 7:02 ` [PATCH v4 2/6] commands/ls: Merge print_files_long and print_files into print_file Glenn Washburn
2025-01-06 7:02 ` [PATCH v4 3/6] commands/ls: Show modification time for file paths Glenn Washburn
2025-01-06 7:02 ` [PATCH v4 4/6] commands/ls: Output path for single file arguments given with path Glenn Washburn
2025-01-06 7:02 ` [PATCH v4 5/6] commands/ls: Print full paths for file args Glenn Washburn
2025-02-24 17:14 ` Daniel Kiper
2025-02-27 6:28 ` Glenn Washburn
2025-02-27 16:27 ` Daniel Kiper
2025-03-01 21:54 ` Glenn Washburn
2025-03-01 22:08 ` Daniel Kiper
2025-01-06 7:02 ` [PATCH v4 6/6] commands/ls: Add directory header for dir args Glenn Washburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1736132547.git.development@efficientek.com \
--to=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.