All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Alexander Duyck <alexanderduyck@fb.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Jason Xing <kernelxing@tencent.com>
Subject: [PATCH v2 net 0/2] net: remove the single page frag cache for good
Date: Tue, 18 Feb 2025 19:29:38 +0100	[thread overview]
Message-ID: <cover.1739899357.git.pabeni@redhat.com> (raw)

This is another attempt at reverting commit dbae2b062824 ("net: skb:
introduce and use a single page frag cache"), as it causes regressions
in specific use-cases.

Reverting such commit uncovers an allocation issue for build with 
CONFIG_MAX_SKB_FRAGS=45, as reported by Sabrina.

This series handle the latter in patch 1 and brings the revert in patch
2.

Note that there is a little chicken-egg problem, as I included into the
patch 1's changelog the splat that would be visible only applying first
the revert: I think current patch order is better for bisectability,
still the splat is useful for correct attribution.

Paolo Abeni (2):
  net: allow small head cache usage with large MAX_SKB_FRAGS values
  Revert "net: skb: introduce and use a single page frag cache"

 include/linux/netdevice.h |   1 -
 include/net/gro.h         |   3 ++
 net/core/dev.c            |  17 ++++++
 net/core/gro.c            |   3 --
 net/core/skbuff.c         | 110 ++++----------------------------------
 5 files changed, 30 insertions(+), 104 deletions(-)

-- 
2.48.1


             reply	other threads:[~2025-02-18 18:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 18:29 Paolo Abeni [this message]
2025-02-18 18:29 ` [PATCH v2 net 1/2] net: allow small head cache usage with large MAX_SKB_FRAGS values Paolo Abeni
2025-02-20  9:41   ` Eric Dumazet
2025-02-18 18:29 ` [PATCH v2 net 2/2] Revert "net: skb: introduce and use a single page frag cache" Paolo Abeni
2025-02-20  9:41   ` Eric Dumazet
2025-02-20 10:10 ` [PATCH v2 net 0/2] net: remove the single page frag cache for good patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1739899357.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=alexanderduyck@fb.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernelxing@tencent.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.