All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Cc: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
Subject: [PATCH 0/4] Fix synchronous fallback path for request chaining
Date: Fri, 21 Mar 2025 16:43:25 +0800	[thread overview]
Message-ID: <cover.1742546178.git.herbert@gondor.apana.org.au> (raw)

It turns out that the fallback path for synchronous algorithms
is broken for ahash and acomp.  It was difficult to identify
because a separate fast path already is normally used for shash
and scomp.  So to reproduce this crash, you would either have to
create a new algorithm that is synchronous, or disable the fast
path for scomp and shash.

This patch series fixes that particular fallback path and adds
multibuffer testing for ahash and acomp.  Note that you may not
be able to reproduce the crash without disabling the fast paths
or adding your own custom synchronous acomp/ahash algorithm that
does not support chaining.

Herbert Xu (4):
  crypto: hash - Fix synchronous ahash chaining fallback
  crypto: testmgr - Add multibuffer hash testing
  crypto: acomp - Fix synchronous acomp chaining fallback
  crypto: testmgr - Add multibuffer acomp testing

 crypto/acompress.c |  33 ++---
 crypto/ahash.c     |  60 +++++----
 crypto/testmgr.c   | 302 ++++++++++++++++++++++++++++++++-------------
 3 files changed, 254 insertions(+), 141 deletions(-)

-- 
2.39.5


             reply	other threads:[~2025-03-21  8:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21  8:43 Herbert Xu [this message]
2025-03-21  8:43 ` [PATCH 1/4] crypto: hash - Fix synchronous ahash chaining fallback Herbert Xu
2025-03-21  8:43 ` [PATCH 2/4] crypto: testmgr - Add multibuffer hash testing Herbert Xu
2025-03-21  8:43 ` [PATCH 3/4] crypto: acomp - Fix synchronous acomp chaining fallback Herbert Xu
2025-03-21  8:43 ` [PATCH 4/4] crypto: testmgr - Add multibuffer acomp testing Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1742546178.git.herbert@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=giovanni.cabiddu@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.