From: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
To: outreachy@lists.linux.dev, gregkh@linuxfoundation.org,
julia.lawall@inria.fr
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
david.laight.linux@gmail.com, andy@kernel.org,
dan.carpenter@linaro.org,
Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Subject: [PATCH v6 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping
Date: Mon, 7 Apr 2025 21:53:50 +0000 [thread overview]
Message-ID: <cover.1744061673.git.abrahamadekunle50@gmail.com> (raw)
Tha patchset adds spaces around binary operators and also
provides clarity on sequence number wrapping by using a modulo operation
% 4096u, in place of the bitwise AND(&) operation & 0xfff.
The patches are required to be applied in sequence.
Changes in v5:
- Converted the patch with the subject "Use % 4096 instead of & 0xfff"
patch to a patchset.
- Added a patch to add spaces around binary operator.
Changes in v4:
- Corrected patch to use '%' instead of '&'.
- To ensure this change does not affect the functional
behaviour, I compared the generated object files before and
after the change using the `cmp` which compares the two
object files byte by byte as shown below:
$ make drivers/staging/rtl8723bs/core/rtw_xmit.o
$ cmp rtw_xmit_before.o rtw_xmit_after.o
No differences were found in the output, confirming that the
change does not alter the compiled output.
Changes in v3:
- Added more description to the commit message.
- Removed blank line in the tag block.
- Added more patch recipients.
Changes in v2:
- Changed the commit message t a more descriptive message which
makes it clear why the patch does the change.
- changed the subject title to include `4096u` to show that an
unsigned module is used.
Changes in v1:
- Added more patch recipients.
Abraham Samuel Adekunle (2):
staging: rtl8723bs: Add white spaces around binary operators
staging: rtl8723bs: Use % 4096u instead of & 0xfff
drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.34.1
next reply other threads:[~2025-04-07 21:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 21:53 Abraham Samuel Adekunle [this message]
2025-04-07 21:53 ` [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators Abraham Samuel Adekunle
2025-04-08 7:19 ` Andy Shevchenko
2025-04-08 9:22 ` Samuel Abraham
2025-04-08 9:35 ` Andy Shevchenko
2025-04-08 10:15 ` Dan Carpenter
2025-04-08 11:51 ` Samuel Abraham
2025-04-08 12:38 ` Dan Carpenter
2025-04-08 12:53 ` Samuel Abraham
2025-04-07 21:53 ` [PATCH v6 2/2] staging: rtl8723bs: Use % 4096u instead of & 0xfff Abraham Samuel Adekunle
2025-04-08 7:20 ` [PATCH v6 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping Andy Shevchenko
2025-04-08 9:28 ` Samuel Abraham
2025-04-08 9:36 ` Andy Shevchenko
2025-04-08 11:46 ` Samuel Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1744061673.git.abrahamadekunle50@gmail.com \
--to=abrahamadekunle50@gmail.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=david.laight.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.