From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
To: fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
ritesh.list@gmail.com, ojaswin@linux.ibm.com, djwong@kernel.org,
zlang@kernel.org, david@fromorbit.com,
nirjhar.roy.lists@gmail.com
Subject: [PATCH v3 0/6] Minor cleanups in common/
Date: Tue, 8 Apr 2025 05:37:16 +0000 [thread overview]
Message-ID: <cover.1744090313.git.nirjhar.roy.lists@gmail.com> (raw)
This patch series removes some unnecessary sourcing of common/rc
and decouples the call to init_rc() from the sourcing of common/rc.
This is proposed in [1] and [2]. It also removes direct usage of exit command
with a _exit wrapper. The individual patches have the details.
[v2] --> [v3]
1. Added R.Bs from Dave[3] and Ritesh in all the patches of [v2]
2. Replaced status=1;exit with "_exit 1" in some of the functions I missed in [v2]
3. Added some comments in the check script(suggested by Ritesh)
4. Added a new patch (patch 2) that removes redundant sourcing of common/config in generic/367
5. As of now, I didn't change the definition of _exit() function.
[1] https://lore.kernel.org/all/20250206155251.GA21787@frogsfrogsfrogs/
[2] https://lore.kernel.org/all/20250210142322.tptpphdntglsz4eq@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/
[3] https://lore.kernel.org/all/Z-xcne3f5Klvuxcq@dread.disaster.area/
[v1] https://lore.kernel.org/all/cover.1741248214.git.nirjhar.roy.lists@gmail.com/
[v2] https://lore.kernel.org/all/cover.1743487913.git.nirjhar.roy.lists@gmail.com/
Nirjhar Roy (IBM) (6):
generic/749: Remove redundant sourcing of common/rc
generic/367: Remove redundant sourcing if common/config
check: Remove redundant _test_mount in check
check,common{rc,preamble}: Decouple init_rc() call from sourcing
common/rc
common/config: Introduce _exit wrapper around exit command
common: exit --> _exit
check | 10 ++---
common/btrfs | 6 +--
common/ceph | 2 +-
common/config | 15 +++++--
common/dump | 11 +++--
common/ext4 | 2 +-
common/populate | 2 +-
common/preamble | 3 +-
common/punch | 13 +++---
common/rc | 107 ++++++++++++++++++++++------------------------
common/repair | 4 +-
common/xfs | 8 ++--
tests/generic/367 | 1 -
tests/generic/749 | 1 -
14 files changed, 91 insertions(+), 94 deletions(-)
--
2.34.1
next reply other threads:[~2025-04-08 5:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 5:37 Nirjhar Roy (IBM) [this message]
2025-04-08 5:37 ` [PATCH v3 1/6] generic/749: Remove redundant sourcing of common/rc Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 2/6] generic/367: Remove redundant sourcing if common/config Nirjhar Roy (IBM)
2025-04-08 9:06 ` Ritesh Harjani
2025-04-09 5:04 ` Zorro Lang
2025-04-08 5:37 ` [PATCH v3 3/6] check: Remove redundant _test_mount in check Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 4/6] check,common{rc,preamble}: Decouple init_rc() call from sourcing common/rc Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 5/6] common/config: Introduce _exit wrapper around exit command Nirjhar Roy (IBM)
2025-04-08 9:13 ` Ritesh Harjani
2025-04-08 16:15 ` Nirjhar Roy (IBM)
2025-04-08 16:32 ` Darrick J. Wong
2025-04-08 16:35 ` Nirjhar Roy (IBM)
2025-04-08 11:35 ` Dave Chinner
2025-04-08 16:43 ` Nirjhar Roy (IBM)
2025-04-09 0:44 ` Dave Chinner
2025-04-09 7:07 ` Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 6/6] common: exit --> _exit Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1744090313.git.nirjhar.roy.lists@gmail.com \
--to=nirjhar.roy.lists@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.