All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
To: fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
	ritesh.list@gmail.com, ojaswin@linux.ibm.com, djwong@kernel.org,
	zlang@kernel.org, david@fromorbit.com, hch@infradead.org,
	nirjhar.roy.lists@gmail.com
Subject: [PATCH v3 0/2] common: Move exit related functions to common/exit
Date: Wed, 30 Apr 2025 12:45:21 +0000	[thread overview]
Message-ID: <cover.1746015588.git.nirjhar.roy.lists@gmail.com> (raw)

This patch series moves all the exit related functions to a separate file -
common/exit. This will remove the dependency to source non-related files to use
these exit related functions. Thanks to Dave for suggesting this[1]. The second
patch replaces exit with _exit in check file - I missed replacing them in [2].

[v2] -> v3
 Addressed Dave's feedbacks.
 In patch [1/2]
  - Removed _die() and die_now() from common/exit
  - Replaced die_now() with _fatal in common/punch
  - Removed sourcing of common/exit and common/test_names from common/config
    and moved them to the beginning of check.
  - Added sourcing of common/test_names in _begin_fstest() since common/config
    is no more sourcing common/test_names.
  - Added a blank line in _begin_fstest() after sourcing common/{exit,test_names}
 In patch [2/2]
  - Replaced "_exit 1" with _fatal and "echo <error message>; _exit 1" with
   _fatal <error message>.
  - Reverted to "exit \$status" in the trap handler registration in check - just
    to make it more obvious to the reader that we are capturing $status as the
    final exit value.

[v1] https://lore.kernel.org/all/cover.1745390030.git.nirjhar.roy.lists@gmail.com/
[v2] https://lore.kernel.org/all/cover.1745908976.git.nirjhar.roy.lists@gmail.com/
[1] https://lore.kernel.org/all/Z_UJ7XcpmtkPRhTr@dread.disaster.area/
[2] https://lore.kernel.org/all/48dacdf636be19ae8bff66cc3852d27e28030613.1744181682.git.nirjhar.roy.lists@gmail.com/


Nirjhar Roy (IBM) (2):
  common: Move exit related functions to a common/exit
  check: Replace exit with _fatal and _exit in check

 check           | 54 ++++++++++++++++++-------------------------------
 common/config   | 17 ----------------
 common/exit     | 39 +++++++++++++++++++++++++++++++++++
 common/preamble |  3 +++
 common/punch    | 39 ++++++++++++++++-------------------
 common/rc       | 28 -------------------------
 6 files changed, 79 insertions(+), 101 deletions(-)
 create mode 100644 common/exit

--
2.34.1


             reply	other threads:[~2025-04-30 12:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 12:45 Nirjhar Roy (IBM) [this message]
2025-04-30 12:45 ` [PATCH v3 1/2] common: Move exit related functions to a common/exit Nirjhar Roy (IBM)
2025-05-01  3:17   ` Ritesh Harjani
2025-05-01  9:10     ` Zorro Lang
2025-05-02  4:23       ` Ritesh Harjani
2025-05-03  3:06         ` Ritesh Harjani
2025-04-30 12:45 ` [PATCH v3 2/2] check: Replace exit with _fatal and _exit in check Nirjhar Roy (IBM)
2025-05-01  3:31   ` Ritesh Harjani
2025-05-02  6:10     ` Nirjhar Roy (IBM)
2025-05-06  8:49 ` [PATCH v3 0/2] common: Move exit related functions to common/exit Nirjhar Roy (IBM)
2025-05-06 15:03   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1746015588.git.nirjhar.roy.lists@gmail.com \
    --to=nirjhar.roy.lists@gmail.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.