All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: mptcp@lists.linux.dev, hare@kernel.org
Cc: Geliang Tang <geliang@kernel.org>
Subject: [PATCH mptcp-next v3 0/4] implement mptcp read_sock
Date: Thu, 26 Jun 2025 16:41:49 +0800	[thread overview]
Message-ID: <cover.1750926916.git.geliang@kernel.org> (raw)

v3:
 - merge the two squash-to patchs.
 - use sk->sk_rcvbuf instead of INT_MAX as the max len in
 mptcp_read_sock().
 - add splice io mode for mptcp_connect and drop mptcp_splice.c test.
 - the splice test for packetdrill is also added here:
https://github.com/multipath-tcp/packetdrill/pull/162

v2:
 - set splice_read of mptcp
 - add a splice selftest.

I have good news! I recently added MPTCP support to "NVME over TCP".
And my RFC patches are under review by NVME maintainer Hannes.

Replacing "NVME over TCP" with MPTCP is very simple. I used IPPROTO_MPTCP
instead of IPPROTO_TCP to create MPTCP sockets on both target and host
sides, these sockets are created in Kernel space.

nvmet_tcp_add_port:

	ret = sock_create(port->addr.ss_family, SOCK_STREAM,
				IPPROTO_MPTCP, &port->sock);

nvme_tcp_alloc_queue:

	ret = sock_create_kern(current->nsproxy->net_ns,
			ctrl->addr.ss_family, SOCK_STREAM,
			IPPROTO_MPTCP, &queue->sock);

nvme_tcp_try_recv() needs to call .read_sock interface of struct
proto_ops, but it is not implemented in MPTCP. So I implemented it
with reference to __mptcp_recvmsg_mskq().

Since the NVME part patches are still under reviewing, I only send the
MPTCP part patches in this set to MPTCP ML for your opinions.

Geliang Tang (4):
  mptcp: use sk_eat_skb in recvmsg_mskq
  mptcp: implement .read_sock
  mptcp: set .splice_read
  selftests: mptcp: add splice io mode

 net/ipv4/tcp.c                                |  6 ++
 net/mptcp/protocol.c                          | 66 ++++++++++++++++++-
 .../selftests/net/mptcp/mptcp_connect.c       | 61 ++++++++++++++++-
 .../selftests/net/mptcp/mptcp_connect.sh      |  9 ++-
 4 files changed, 138 insertions(+), 4 deletions(-)

-- 
2.48.1


             reply	other threads:[~2025-06-26  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26  8:41 Geliang Tang [this message]
2025-06-26  8:41 ` [PATCH mptcp-next v3 1/4] mptcp: use sk_eat_skb in recvmsg_mskq Geliang Tang
2025-06-26  8:41 ` [PATCH mptcp-next v3 2/4] mptcp: implement .read_sock Geliang Tang
2025-06-26  8:41 ` [PATCH mptcp-next v3 3/4] mptcp: set .splice_read Geliang Tang
2025-06-26  8:41 ` [PATCH mptcp-next v3 4/4] selftests: mptcp: add splice io mode Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1750926916.git.geliang@kernel.org \
    --to=geliang@kernel.org \
    --cc=hare@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.