From: Abdun Nihaal <abdun.nihaal@gmail.com>
To: andy@kernel.org
Cc: Abdun Nihaal <abdun.nihaal@gmail.com>,
dan.carpenter@linaro.org, gregkh@linuxfoundation.org,
lorenzo.stoakes@oracle.com, tzimmermann@suse.de,
riyandhiman14@gmail.com, willy@infradead.org, notro@tronnes.org,
thomas.petazzoni@free-electrons.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] staging: fbtft: cleanup fbtft_framebuffer_alloc()
Date: Tue, 1 Jul 2025 15:10:21 +0530 [thread overview]
Message-ID: <cover.1751361715.git.abdun.nihaal@gmail.com> (raw)
Cleanup error handling in fbtft_framebuffer_alloc()
This patchset includes the revert commit for the v1 patch, and the
cleanup patch that is not yet applied.
I have not included the v3 patch ("staging: fbtft: fix potential memory
leak in fbtft_framebuffer_alloc()") in this patchset, as it has been
already applied on staging-testing
v4:
- Add a revert patch to remove v1 patch
- Not included the patch that is already applied on staging-testing
- Added Reviewed-by tags
v3:
- Remove a redundant check before calling kfree
v2:
- Change the earlier patch to also handle the error code returned by
fb_deferred_io_init() and update Fixes tag to point to the commit that
introduced the memory allocation (which leads to leak).
- Add second patch to make the error handling order symmetric to
fbtft_framebuffer_release() and also remove managed allocation for
txbuf as suggested by Andy and Dan.
Link to v3: https://lore.kernel.org/linux-staging/cover.1751207100.git.abdun.nihaal@gmail.com/
Link to v2: https://lore.kernel.org/linux-staging/cover.1751086324.git.abdun.nihaal@gmail.com/T/#md111471ddd69e6ddb0a6b98e565551ffbd791a34
Link to v1: https://lore.kernel.org/all/20250626172412.18355-1-abdun.nihaal@gmail.com/
Abdun Nihaal (2):
Revert "staging: fbtft: fix potential memory leak in
fbtft_framebuffer_alloc()"
staging: fbtft: cleanup error handling in fbtft_framebuffer_alloc()
drivers/staging/fbtft/fbtft-core.c | 32 +++++++++++++++---------------
1 file changed, 16 insertions(+), 16 deletions(-)
--
2.43.0
next reply other threads:[~2025-07-01 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 9:40 Abdun Nihaal [this message]
2025-07-01 9:40 ` [PATCH v4 1/2] Revert "staging: fbtft: fix potential memory leak in fbtft_framebuffer_alloc()" Abdun Nihaal
2025-07-01 13:48 ` Andy Shevchenko
2025-07-01 14:16 ` Dan Carpenter
2025-07-01 14:19 ` Greg KH
2025-07-01 14:13 ` Dan Carpenter
2025-07-01 9:40 ` [PATCH v4 2/2] staging: fbtft: cleanup error handling in fbtft_framebuffer_alloc() Abdun Nihaal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1751361715.git.abdun.nihaal@gmail.com \
--to=abdun.nihaal@gmail.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=notro@tronnes.org \
--cc=riyandhiman14@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.