All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nam Cao <namcao@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Gabriele Monaco <gmonaco@redhat.com>,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Nam Cao <namcao@linutronix.de>
Subject: [PATCH 0/2] rv: Fix wrong type cast
Date: Sun, 27 Jul 2025 19:31:11 +0200	[thread overview]
Message-ID: <cover.1753625621.git.namcao@linutronix.de> (raw)

Hi,

After my previous rv simplification series:
https://lore.kernel.org/linux-trace-kernel/cover.1753378331.git.namcao@linutronix.de/T/#t

Some RV's available/enabled reactors/monitors files do not work anymore:

    root@yellow:~# cat /sys/kernel/tracing/rv/available_monitors
    nop: �������`������� ���������Z������u�����-s�����
    nop:���������������� �������@>H�����

    nop:
    ��������
    ��������8�������:��������
    `���������������

    root@yellow:~# cat /sys/kernel/tracing/rv/available_reactors
    ��������8�������
    P�������x�������
    8����������������^�����81s������I?�������������8�������

It turned out that there has been a type cast mistake in RV all this time,
but it still happened to work. Due to the recent refactor, the mistaken
type cast got "promoted" and became a real problem.

This series fixes up this type cast.

Nam Cao (2):
  rv: Fix wrong type cast in monitors_show()
  rv: Fix wrong type cast in reactors_show() and monitor_reactor_show()

 kernel/trace/rv/rv.c          | 2 +-
 kernel/trace/rv/rv_reactors.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.39.5


             reply	other threads:[~2025-07-27 17:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 17:31 Nam Cao [this message]
2025-07-27 17:31 ` [PATCH 1/2] rv: Fix wrong type cast in monitors_show() Nam Cao
2025-07-28  8:59   ` Gabriele Monaco
2025-07-28  9:36     ` Nam Cao
2025-07-28 11:07       ` Gabriele Monaco
2025-07-27 17:31 ` [PATCH 2/2] rv: Fix wrong type cast in reactors_show() and monitor_reactor_show() Nam Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1753625621.git.namcao@linutronix.de \
    --to=namcao@linutronix.de \
    --cc=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.