From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs-progs: check for device item between super
Date: Sat, 2 Aug 2025 09:56:18 +0930 [thread overview]
Message-ID: <cover.1754090561.git.wqu@suse.com> (raw)
Mark has submitted a check enhancement for progs to detect the device
item mismatch between super blocks and the items inside chunk tree.
However there is a long existing problem that it will break CI.
The root cause is that the CI kernel lacks the needed backports, that on
a lot cases the kernel can lead to such mismatch and being caught by the
newer progs.
So to merge this long existing fsck enhancement, this series refresh and
workaround the problem by:
- Only reports warnings when such mismatch is detected
Such mismatch is not a huge deal, as we always trust the device item in
chunk tree more than the super block one.
So it won't cause data loss or whatever.
So even if the CI kernel doesn't have the fix, self test cases won't
report them as a failure.
- Workaround fsck/057 to avoid failure
Test case fsck/057 is a special case, where we manually check the
output for warning messages.
This is originally to detect problems related seed device, but now it
will also detect device item mismatch cause by the older CI kernel.
Workaround it by making the keyword more specific to the original
problem, not just checking for warnings.
With those done, we can finally make CI to accept the new checks even
the kernel is not uptodate.
Mark Harmstone (1):
btrfs-progs: check that device byte values in superblock match those
in chunk root
Qu Wenruo (1):
btrfs-progs: fsck-tests: make the warning check more specific for 057
check/main.c | 35 +++++++++++++++++++
.../fsck-tests/057-seed-false-alerts/test.sh | 6 ++--
2 files changed, 38 insertions(+), 3 deletions(-)
--
2.50.1
next reply other threads:[~2025-08-02 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-02 0:26 Qu Wenruo [this message]
2025-08-02 0:26 ` [PATCH 1/2] btrfs-progs: fsck-tests: make the warning check more specific for 057 Qu Wenruo
2025-08-02 0:26 ` [PATCH 2/2] btrfs-progs: check that device byte values in superblock match those in chunk root Qu Wenruo
2025-08-05 19:34 ` [PATCH 0/2] btrfs-progs: check for device item between super Boris Burkov
2025-08-05 22:53 ` Qu Wenruo
2025-08-05 23:26 ` Boris Burkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1754090561.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.