From: Boris Burkov <boris@bur.io>
To: linux-btrfs@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, kernel-team@fb.com
Cc: shakeel.butt@linux.dev, hch@infradead.org, wqu@suse.com
Subject: [PATCH 0/3] filemap_add_folio_nocharge()
Date: Tue, 5 Aug 2025 17:11:46 -0700 [thread overview]
Message-ID: <cover.1754438418.git.boris@bur.io> (raw)
I would like to revisit Qu's proposal to not charge btrfs extent_buffer
allocations to the user's cgroup.
https://lore.kernel.org/linux-mm/b5fef5372ae454a7b6da4f2f75c427aeab6a07d6.1727498749.git.wqu@suse.com/
I believe it is detrimental to randomly account these global pages to
the cgroup using them, basically at random. A bit more justification
and explanation in the patches themselves.
Three meta-considerations/questions:
1. Which tree should this go through, assuming it is acceptable?
For now, I have based it off btrfs/for-next as that is what I am
used to doing, but I am happy to re-send it based off the appropriate mm
branch.
2. Christoph wrote the first patch as-is in his suggestion to Qu. I am happy
to replace it with his authorship/s-o-b, I just didn't want to do that
without asking. For now, I put his "Suggested-by".
3. The previous suggestion also requested "proper" documentation. I don't
know what that entails in this case, and was unable to find corresponding
documentation for filemap_add_folio() in the code or in Documentation/.
Please let me know what I should be doing there, as well.
Boris Burkov (3):
mm/filemap: add filemap_add_folio_nocharge()
btrfs: use filemap_add_folio_nocharge() for extent_buffers
mm: add vmstat for cgroup uncharged pages
fs/btrfs/extent_io.c | 4 ++--
include/linux/mmzone.h | 3 +++
include/linux/pagemap.h | 2 ++
mm/filemap.c | 41 +++++++++++++++++++++++++++++++++++------
mm/vmstat.c | 3 +++
5 files changed, 45 insertions(+), 8 deletions(-)
--
2.50.1
next reply other threads:[~2025-08-06 0:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 0:11 Boris Burkov [this message]
2025-08-06 0:11 ` [PATCH 1/3] mm/filemap: add filemap_add_folio_nocharge() Boris Burkov
2025-08-06 0:11 ` [PATCH 2/3] btrfs: use filemap_add_folio_nocharge() for extent_buffers Boris Burkov
2025-08-06 0:11 ` [PATCH 3/3] mm: add vmstat for cgroup uncharged pages Boris Burkov
2025-08-06 20:40 ` kernel test robot
2025-08-06 20:51 ` kernel test robot
2025-08-07 17:23 ` Shakeel Butt
2025-08-06 14:00 ` [PATCH 0/3] filemap_add_folio_nocharge() Matthew Wilcox
2025-08-06 23:19 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1754438418.git.boris@bur.io \
--to=boris@bur.io \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeel.butt@linux.dev \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.