All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Pravdin <ipravdin.official@gmail.com>
To: rostedt@goodmis.org, corbet@lwn.net, tglozar@redhat.com,
	linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Ivan Pravdin <ipravdin.official@gmail.com>
Subject: [PATCH 0/3] rtla: fix cgroup and trace options parsing
Date: Tue, 12 Aug 2025 12:27:29 -0400	[thread overview]
Message-ID: <cover.1755014784.git.ipravdin.official@gmail.com> (raw)

This series fixes 3 issue in rtla timerlat and osnoise parsing.

1. Fix buffer overflow when using --on-threshold option. Currently
   passing `--on-threshold trace` causes rtla timerlat to segfault.
   First patch addresses this issue.

2. Make -C/--cgroup option more user-friendly. Currently rtla timerlat
   and osnoise parses does not allow to specify tracer's threads cgroup
   name as `-C [cgroup]` or `--cgroup [cgroup]`. Second patch fixes this by
   allowing users to specify cgroup in the aforementioned manner.

3. When specifying `-t/--trace` before `-a/--auto`, trace filename is
   override to default <osnoise|timerlat>_trace.txt. For example, when
   running rtla as 
    
       `rtla timerlat top -t custom_file.txt -a 100`

   when the threshold is reached, timerlat_trace.txt file is created
   instead of specified custom_file.txt. Third patch addresses this issue.

Ivan Pravdin (3):
  rtla: fix buffer overflow in actions_parse
  rtla: fix -C/--cgroup interface
  rtla: fix -a overriding -t argument

 Documentation/tools/rtla/common_options.rst |  2 +-
 tools/tracing/rtla/src/actions.c            |  2 +-
 tools/tracing/rtla/src/osnoise_hist.c       | 24 ++++++++------
 tools/tracing/rtla/src/osnoise_top.c        | 24 ++++++++------
 tools/tracing/rtla/src/timerlat_hist.c      | 24 ++++++++------
 tools/tracing/rtla/src/timerlat_top.c       | 36 +++++++++------------
 6 files changed, 62 insertions(+), 50 deletions(-)

-- 
2.48.1


             reply	other threads:[~2025-08-12 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 16:27 Ivan Pravdin [this message]
2025-08-12 16:27 ` [PATCH 1/3] rtla: fix buffer overflow in actions_parse Ivan Pravdin
2025-08-12 16:27 ` [PATCH 2/3] rtla: fix -C/--cgroup interface Ivan Pravdin
2025-08-12 16:27 ` [PATCH 3/3] rtla: fix -a overriding -t argument Ivan Pravdin
2025-08-12 17:23 ` [PATCH 0/3] rtla: fix cgroup and trace options parsing Ivan Pravdin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1755014784.git.ipravdin.official@gmail.com \
    --to=ipravdin.official@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.