From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Philip Blundell <philb@gnu.org>,
Kars de Jong <jongk@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 0/2] tty: serial: 8250: Rework HP300 serial Kconfig logic
Date: Mon, 8 Sep 2025 11:45:40 +0200 [thread overview]
Message-ID: <cover.1757323858.git.geert@linux-m68k.org> (raw)
Hi all,
The HP300 serial driver has a long-standing configuration issue: when
SERIAL_8250 and HP300 are enabled, but none of HPDCA and HPAPCI is
built-in:
drivers/tty/serial/8250/8250_hp300.c:24:2: warning: #warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure? [-Wcpp]
24 | #warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
| ^~~~~~~
This series fixes this by reworking the Kconfig logic to make invalid
configurations impossible, after moving the HP300 serial suboptions to
where they really belong. It is meant as a replacement for "[PATCH]
m68k: make HPDCA and HPAPCI bools" [1], and was compile-tested only.
Anyone who can test this one real hardware?
Probably we should add the following to hp300_defconfig:
+CONFIG_SERIAL_8250=y
+# CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set
+# CONFIG_SERIAL_8250_16550A_VARIANTS is not set
+CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_8250_HPDCA=y
+CONFIG_SERIAL_8250_HPAPCI=y
Thanks for your comments!
[1] https://lore.kernel.org/all/20250822104208.751191-1-jirislaby@kernel.org
Geert Uytterhoeven (2):
tty: serial: 8250: Move HP300/400 serial Kconfig options
tty: serial: 8250: Rework HP300 serial Kconfig logic
arch/m68k/Kconfig.devices | 14 -------------
drivers/tty/serial/8250/8250_hp300.c | 30 ++++++++++++----------------
drivers/tty/serial/8250/Kconfig | 16 ++++++++++++++-
3 files changed, 28 insertions(+), 32 deletions(-)
--
2.43.0
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2025-09-08 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 9:45 Geert Uytterhoeven [this message]
2025-09-08 9:45 ` [PATCH 1/2] tty: serial: 8250: Move HP300/400 serial Kconfig options Geert Uytterhoeven
2025-09-08 9:45 ` [PATCH 2/2] tty: serial: 8250: Rework HP300 serial Kconfig logic Geert Uytterhoeven
2025-09-08 10:07 ` [PATCH 0/2] " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1757323858.git.geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jongk@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
--cc=philb@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.