All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olamide Caleb Bello <belkid98@gmail.com>
To: git@vger.kernel.org
Cc: christian.couder@gmail.com, gitster@pobox.com,
	usmanakinyemi202@gmail.com,
	Olamide Caleb Bello <belkid98@gmail.com>
Subject: [Outreachy PATCH v2 0/2] gpg-interface.c: use string_list_split() instead of strbuf_split_max()
Date: Thu, 16 Oct 2025 01:03:52 +0000	[thread overview]
Message-ID: <cover.1760571220.git.belkid98@gmail.com> (raw)

Commit 2efe707054 (wt-status: avoid strbuf_split*(), 2025-07-31) noticed
that the array of strbufs that calls to strbuf_split*() provides are merely
used to store the strings gotten from the split and no edit are
done on these resulting strings making the strbuf_split*() unideal
for this usecase, with the string_list_split*() being a more suitable option.

The patch series by Junio Hamano can be seen in the link below.

https://public-inbox.org/git/20250731225433.4028872-1-gitster@pobox.com/

This series continues on this path by replacing instances of
strbuf_split_max() with string_list_split() where the string from the
split is merely returned as char * and no edits are done on them.

Changes since v1
================
 - Added commit reference and link to patch series for previous work
 done on the subject


Olamide Caleb Bello (2):
  gpg-interface: replace strbuf_split_max() with string_list_split()
  gpg-interface: use string_list_split() instead of strbuf_split_max()

 gpg-interface.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

-- 
2.51.0.463.g79cf913ea9


             reply	other threads:[~2025-10-16  1:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  1:03 Olamide Caleb Bello [this message]
2025-10-16  1:03 ` [Outreachy PATCH v2 1/2] gpg-interface: replace strbuf_split_max() with string_list_split() Olamide Caleb Bello
2025-10-16 17:27   ` Junio C Hamano
2025-10-17  9:15     ` Christian Couder
2025-10-17 10:07       ` Bello Olamide
2025-10-17 18:47       ` Junio C Hamano
2025-10-17 10:53     ` Bello Olamide
2025-10-16  1:03 ` [Outreachy PATCH v2 2/2] gpg-interface: use string_list_split() instead of strbuf_split_max() Olamide Caleb Bello
2025-10-17  7:58 ` [Outreachy PATCH v2 0/2] gpg-interface.c: " Christian Couder
2025-10-17  9:54   ` Bello Olamide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1760571220.git.belkid98@gmail.com \
    --to=belkid98@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.