From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 360C0CCFA00 for ; Sat, 1 Nov 2025 12:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:Message-ID:Date:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=AeKmeDWz+TekgvPEKdR/I65V1vqlcCMt3KOSU8nq+YU=; b=QoVR/1v1xkrjeTosQaAdeluUyi uY9zUrYCmAlnVycaXVfm7t961qy+tLI65Z0Eo9CbaQ59iabMtpwa3GU/JXzd1+tH6QNPxye5GvBN0 U9mMRG2qbbnW+N9BXbwXJ+Cnj1ec3AQ0dTBs6moGi921t96d0R8tnfXZXpkerakKSr34=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vFBA8-0002Wi-Dr; Sat, 01 Nov 2025 12:56:57 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vFBA6-0002WO-E8 for linux-f2fs-devel@lists.sourceforge.net; Sat, 01 Nov 2025 12:56:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wGVmb1DJ+yAOnx5AlPbC58cKdV6J05JG0r5lqYgWdxk=; b=devnb8c05Y34Nulg4fr+KNbt9n d0BWdYa63XPXCjEuayFN35W014sdoWsWKlFCE4D6BkdQtpamFdEIzn/bLt8/LosA1p46uJkg6yC+M dyvRUPhxjuipwlJN0PdkYUsWUHc71Ja8ikqPx3CT0bYGr2AqveQXu/rEVuqCTdH3Rrk4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=wGVmb1DJ+yAOnx5AlPbC58cKdV6J05JG0r5lqYgWdxk=; b=A 3Vo1tX34rtLr3szQqNnERVBGYDhW8VY+PngW6zLx30JRLdEAh8xIGJAutIvzr3j3jt4S631416VVo iFYViIgspYrr6P79Yjke7rFPDM8VyEyE15fdRh1ELgMR9v+BlGAHHCAt5JlaGYpMCEP7A3EsrXbhR p6Bk+t7oGZ8ZDG3Q=; Received: from mail-wm1-f51.google.com ([209.85.128.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1vFBA6-0008P4-Mx for linux-f2fs-devel@lists.sourceforge.net; Sat, 01 Nov 2025 12:56:55 +0000 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-475dd559b0bso40206875e9.1 for ; Sat, 01 Nov 2025 05:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762001803; x=1762606603; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wGVmb1DJ+yAOnx5AlPbC58cKdV6J05JG0r5lqYgWdxk=; b=Skqts4Q9VSosO2h/MUBPfVgSKrQfNrRjiL+kYq7jKUBF1LGrxT7n89YFB7j7lwYtEE 5usQYstebZzNJvPaIFK+f62fvwd1v7CYCELe3msjchXTzc6uXfu1t/cwjWnjLiDsgRft 4Co4QvAs4MmFuF8n2vZFqEd78d/TXhlRt3gXPdvUIuNh+UCu7QcMuSpsBMGiDGG/OP/8 7YaX4EmshAxqZ8kR7w5YBVCB3zXYQns7Irzk0anAPd57vObJ/xiDgM5cjCdKtnX/AIkp SnA7Bd9v980kM69ap5IR1626+HKAoDNxu6S3lo8xPXEtXt9Ti1xoWSCpkpvrcknCZoh6 4hvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762001803; x=1762606603; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wGVmb1DJ+yAOnx5AlPbC58cKdV6J05JG0r5lqYgWdxk=; b=gMtsToGmuy6eaR/yMuPmbUdqWseHBAxxLxge74v67ThFGm6LQ9qIn6+mI7ttoBTHue IVK3gTqvbGO1WW3PJHNchh8BmdrmIPmN9Kj5mGVMYR4B4IXDlF9qyIUAaKYH2Q7W+H7D tttS9gN9lV4+5EQsP3O6HysoKxVCVcruvXuoP0xxbZptirgSccw4sb8wL2zOKDbA96i5 CpBDUNvDxaM021nLKVIK/Zy5Toc9CtoYoyw1l0H8GW9o+95JoaacpA84GL1lyztl5Zqv PRIYgRD4AM8ONStHu1e0tjbk7PT5wdTjVL1nn7xQAQd18kqFuk7FsmlmCF+h38NhHFgI +c6A== X-Forwarded-Encrypted: i=1; AJvYcCVAIuWJY1wZ/WwOZJcmrYQNLSt74EPfC7TbLz23df9GW3PbbvJT026hPx+Qe5fC+PfgHWfSXh5iT/i9WWPZl7p3@lists.sourceforge.net X-Gm-Message-State: AOJu0YzOdcoJZF92RNHuYRTEw0JIAuZr+CcO1sqi7KGRTq/o/A7AcjS8 lrnlYQp7pbkdLSIY5Ero4fUqkUpcH7KIdijX1eNe00wmbbANwEE4T/+9 X-Gm-Gg: ASbGncskzk6JXFt0kKF5EA1IfqxONQ/jEDAlaB8/NPUe0xl/tqvDieywqL3vaQS1r6N ScnCQVS6EiaCVdOauPlTSKRvIL6X8TmP+Atn/YPUtQIPPgEOsYRkFLMNme5TUnKRt/GNAt9R9nK MnLHRlQAQlpIbEmPIXnVPPXL+lv5jmxUu9oM8oQficUncM/fXM5m0F6ethObE/0KOQ6zacRpyFX g6FsuJEeouxu9mKiSMf/47Ws0qNculLGhoxg4kjSw1q7Gh43wTM2acNwbF4AQ6B9pa59ffQVc0F 2BzGdVDN37GrH3za/wuyI2WcTcIBjx7rucM//0/fdox72WgFGCEud83sViuIFpoWZXAwdQ/I9iv v6vrmAdl9HfxqBv94MNMSQDXJEGeTVI730NPCD/ubPVdkH3ekY//DkA4rguDExUTCuIHBS3VtrE Iim31poE7i9DioZyjun4nlPg== X-Google-Smtp-Source: AGHT+IF67+MB9gNMQj44RfGkbRUyMVSRr8JGv/Vb3x0BucDfXENO6/yD2+Bv+4xEmQGnVJYrNs47/g== X-Received: by 2002:a05:600c:444b:b0:477:c71:1fc1 with SMTP id 5b1f17b1804b1-477308b7d81mr67818705e9.19.1762001802876; Sat, 01 Nov 2025 05:56:42 -0700 (PDT) Received: from localhost.localdomain ([46.10.223.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c13f2b5asm8827647f8f.40.2025.11.01.05.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Nov 2025 05:56:42 -0700 (PDT) From: "Nikola Z. Ivanov" To: jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Sat, 1 Nov 2025 14:56:14 +0200 Message-ID: X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Headers-End: 1vFBA6-0008P4-Mx Subject: [f2fs-dev] [PATCH v2 0/2] f2fs: Add sanity checks before unlinking and loading inodes X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david.hunter.linux@gmail.com, linux-kernel@vger.kernel.org, khalid@kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, "Nikola Z. Ivanov" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net This series is provoked by syzbot warnings caused by corrupted directory inode with i_nlink == 1 that passes the initial sanity check which will only mark the filesystem as corrupted in case i_nlink == 0. Tests: - fio/fsmark parallel create/unlink on VM with f2fs root filesystem. - syzbot Changelog: Changes from v1: - Rename exit label in f2fs_unlink(). - Add sanity check in sanity_check_inode() and remove it from f2fs_iget(). as suggested by Chao Yu in order to detect on-disk corruption early. https://lore.kernel.org/linux-f2fs-devel/d4b7c03c-6554-4407-b823-aecfcdf7dc3f@kernel.org/T/#t Nikola Z. Ivanov (2): f2fs: Rename f2fs_unlink exit label f2fs: Add sanity checks before unlinking and loading inodes fs/f2fs/inode.c | 10 ++++++++++ fs/f2fs/namei.c | 27 +++++++++++++++++---------- 2 files changed, 27 insertions(+), 10 deletions(-) -- 2.51.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F30912C234B for ; Sat, 1 Nov 2025 12:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762001808; cv=none; b=AXwgXeM7iv3pBqe3JpeiBJJMbFkqxKyNxMbdAxm8NGufeVlqK9+UnFVNnVJyDra6X6dhDzK7/moqC4oQ5qO8py8JEKkPm7cLud+XrL2OY1TCHb2IXtH9TkwdsZImHv4ojHHVA0K4tRz979pYi6N6z2crCI1YN4WoVSk/J8LCPag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762001808; c=relaxed/simple; bh=bY9blcWwS6sUmcL8NElBTzi1r0kjFCooMSoEK5zz8Ok=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Jc581zp+zKKKYK4OBt6NanM1D0BVLt75CYOoGSEXAvNwQFl6wwPQ2yCAxqAYzH5LOiqT5Ed5aQb1IGZVjiXr35Qdx6FRKSavC6ULmlAt3PB0ZGjaaEubRPrFG5H5b4KXTAllI7Wu0t+Ix12CZmFuyM6h3dGKgc2+ulw+TtEhvk0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m+OQtO+M; arc=none smtp.client-ip=140.211.166.137 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m+OQtO+M" Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7D9854145E for ; Sat, 1 Nov 2025 12:56:46 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org X-Spam-Flag: NO X-Spam-Score: -2.099 X-Spam-Level: Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id H2QvsovKWhkz for ; Sat, 1 Nov 2025 12:56:45 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::330; helo=mail-wm1-x330.google.com; envelope-from=zlatistiv@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 5E3D541447 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5E3D541447 Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=m+OQtO+M Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5E3D541447 for ; Sat, 1 Nov 2025 12:56:45 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4710a1f9e4cso25162045e9.0 for ; Sat, 01 Nov 2025 05:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762001803; x=1762606603; darn=lists.linuxfoundation.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wGVmb1DJ+yAOnx5AlPbC58cKdV6J05JG0r5lqYgWdxk=; b=m+OQtO+MZadL6BlYoqnCq0UbFs6TJwm3IIDCXLqMAT3oZeLsiA73W2lM87vC8PJEyZ M1ZNf3yC/m1tUVpkJ2/Qx0yWPQv3T6NxJtEwxBwovTe/S8tXOtoEd/5t/eoyKQguyFZR lqLLeh8K6hRtEEwM0xKKx6pGUHSbFnc6k/niF5ASqP7L8bwZRTEDogtWtfvThv8D1p9q t7WmqcAEyddkVPb6tpuiRcFn6xRWHL5czZLR3zY1ZMjgzmzqEw+krliuLwVhzfwkGt+J aingkI+LxkOLGfcMXcK2sLD16kE2RTLpnFNc/SWu6tRqaO5y6y8puUz41Q36aeLVsw8Q yuPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762001803; x=1762606603; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wGVmb1DJ+yAOnx5AlPbC58cKdV6J05JG0r5lqYgWdxk=; b=dWK9IW5rzBH1YObTJ17fPsCYrz1JU/P90u3ZlyCMDlUJ0QwswwVEbF8c35St3aFbtl BrVQkMCY8VQXwz2OYxvb1QY+IwOmnK69xP0GVDmC+ccP4GU4xfUPr64d2r+9Hx753gsM +vVdrvMStKZkjDdpyhdVsQvYrUFylVXBOUBvmPpZ5MrWcTjs57f3xOQ7VTw4GIH/by6G jB14S+AfzGfqi3ReoePijWHvPsT9Cnr/MJCBtEafh6uhEgihSvC9RxWubtn36AYETNdu ZRDOzpS/6bQO+ZIXB8T+g483abIgBjijpkYGI/SCCAuAOrMcrf2YPB0VnJHwjmgjW94F pUSg== X-Forwarded-Encrypted: i=1; AJvYcCUxo22JeSueS7lm8ltYkjtxyaMQw6QmiJprEOtaxA+VbunN+ockc5CX6bjjV8qAFZeJ1Ro/fECdhTiE8ASicWmsWLdYSg==@lists.linuxfoundation.org X-Gm-Message-State: AOJu0YyOARqLqATRrNUgIl0FH/tL3dvwOtUtF6p1KuaMRrJarLyAkBKx AIMYC+1oapWdO+24ldFuemoTpFtmW+VhGmQpxf4KSlLO/Fl2bClbfdYk X-Gm-Gg: ASbGnct8NgBGiFNVP0dQteLaHfezl5OI9+cABKWV1zKRHroy3yziQajxArdJIkvdp2h eA5NsCGPXndfidTFIjjGIIB1QNg/u+kJ9RTwsGEFXEbklQi0lNCXhpfLm6oBFZ43TieokWccUWp Rcss111AHpffxY3UzpQPj38d3RSFvjjezA3BSKTEwVujkPI1S8SpIwwxGb2Vl3fh2mgSCz6EDU8 k+Eg993LexPwmZnUcif6fL2TxnAb3ojjSm6twvokKl3NSt/sY4ZP1GjOtbs9MoEcV9u2gHPzhhD W0U+zYTmfrglYOO2BQLs0qL1PuYbzpEFDR1FS6fhnNZBLX+eKI7U9o+4pfJA4sWNGqNs+EQuT97 uaq0KeM4QQEyN3qqqCOtdZ8amPfw0dFFZ1McuMwlYgajuuP7snB/42iCGrppiLDN5w12CcCNb5+ TKn+xXEt7Vn5AnwOteDTORPw== X-Google-Smtp-Source: AGHT+IF67+MB9gNMQj44RfGkbRUyMVSRr8JGv/Vb3x0BucDfXENO6/yD2+Bv+4xEmQGnVJYrNs47/g== X-Received: by 2002:a05:600c:444b:b0:477:c71:1fc1 with SMTP id 5b1f17b1804b1-477308b7d81mr67818705e9.19.1762001802876; Sat, 01 Nov 2025 05:56:42 -0700 (PDT) Received: from localhost.localdomain ([46.10.223.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c13f2b5asm8827647f8f.40.2025.11.01.05.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Nov 2025 05:56:42 -0700 (PDT) From: "Nikola Z. Ivanov" To: jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, khalid@kernel.org, "Nikola Z. Ivanov" Subject: [PATCH v2 0/2] f2fs: Add sanity checks before unlinking and loading inodes Date: Sat, 1 Nov 2025 14:56:14 +0200 Message-ID: X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is provoked by syzbot warnings caused by corrupted directory inode with i_nlink == 1 that passes the initial sanity check which will only mark the filesystem as corrupted in case i_nlink == 0. Tests: - fio/fsmark parallel create/unlink on VM with f2fs root filesystem. - syzbot Changelog: Changes from v1: - Rename exit label in f2fs_unlink(). - Add sanity check in sanity_check_inode() and remove it from f2fs_iget(). as suggested by Chao Yu in order to detect on-disk corruption early. https://lore.kernel.org/linux-f2fs-devel/d4b7c03c-6554-4407-b823-aecfcdf7dc3f@kernel.org/T/#t Nikola Z. Ivanov (2): f2fs: Rename f2fs_unlink exit label f2fs: Add sanity checks before unlinking and loading inodes fs/f2fs/inode.c | 10 ++++++++++ fs/f2fs/namei.c | 27 +++++++++++++++++---------- 2 files changed, 27 insertions(+), 10 deletions(-) -- 2.51.0