All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trondmy@kernel.org>
To: Michael Stoler <michael.stoler@vastdata.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/3] Fix verifier initialisation races for dentries
Date: Wed, 19 Nov 2025 08:58:23 -0500	[thread overview]
Message-ID: <cover.1763560328.git.trond.myklebust@hammerspace.com> (raw)
In-Reply-To: <53bc46637bdc4b267a318c74fb4c97cb382f29d1.camel@kernel.org>

From: Trond Myklebust <trond.myklebust@hammerspace.com>

Michael Stoler reports seeing an issue in which an uninitialised
verifier on a dentry is causing an incorrect revalidation. This again is
causing him to see a removed file as being still present during an
exclusive create.
The fix should be to ensure that all verifiers are initialised before
calling d_splice_alias().

Trond Myklebust (3):
  NFS: Initialise verifiers for visible dentries in readdir and lookup
  NFS: Initialise verifiers for visible dentries in nfs_atomic_open()
  NFS: Initialise verifiers for visible dentries in
    _nfs4_open_and_get_state

 fs/nfs/dir.c      |  8 +++++---
 fs/nfs/nfs4proc.c | 27 ++++++++++++++-------------
 2 files changed, 19 insertions(+), 16 deletions(-)

-- 
2.51.1


  reply	other threads:[~2025-11-19 13:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 10:52 Spurious -EEXIST from NFSv3 Michael Stoler
2025-11-19 13:48 ` Trond Myklebust
2025-11-19 13:58   ` Trond Myklebust [this message]
2025-11-19 13:58     ` [PATCH 1/3] NFS: Initialise verifiers for visible dentries in readdir and lookup Trond Myklebust
2025-11-19 13:58     ` [PATCH 2/3] NFS: Initialise verifiers for visible dentries in nfs_atomic_open() Trond Myklebust
2025-11-19 13:58     ` [PATCH 3/3] NFS: Initialise verifiers for visible dentries in _nfs4_open_and_get_state Trond Myklebust
2025-11-19 16:14       ` Anna Schumaker
2025-11-19 16:50         ` Trond Myklebust
2025-11-20 10:47       ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1763560328.git.trond.myklebust@hammerspace.com \
    --to=trondmy@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=michael.stoler@vastdata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.