All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "Cong Wang" <xiyou.wangcong@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Olivia Mackall" <olivia@selenic.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Jason Wang" <jasowang@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Petr Tesarik" <ptesarik@suse.com>,
	"Leon Romanovsky" <leon@kernel.org>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Bartosz Golaszewski" <brgl@kernel.org>,
	linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org,
	virtualization@lists.linux.dev, linux-scsi@vger.kernel.org,
	iommu@lists.linux.dev, kvm@vger.kernel.org,
	netdev@vger.kernel.org
Subject: [PATCH v2 00/15] fix DMA aligment issues around virtio
Date: Mon, 5 Jan 2026 03:22:50 -0500	[thread overview]
Message-ID: <cover.1767601130.git.mst@redhat.com> (raw)


Cong Wang reported dma debug warnings with virtio-vsock
and proposed a patch, see:

https://lore.kernel.org/all/20251228015451.1253271-1-xiyou.wangcong@gmail.com/

however, the issue is more widespread.
This is an attempt to fix it systematically.
Note: i2c and gio might also be affected, I am still looking
into it. Help from maintainers welcome.

Lightly tested.  Cursor/claude used liberally, mostly for
refactoring/API updates/English.

DMA maintainers, could you please confirm the DMA core changes
are ok with you?

Thanks!


Michael S. Tsirkin (15):
  dma-mapping: add __dma_from_device_group_begin()/end()
  docs: dma-api: document __dma_from_device_group_begin()/end()
  dma-mapping: add DMA_ATTR_CPU_CACHE_CLEAN
  docs: dma-api: document DMA_ATTR_CPU_CACHE_CLEAN
  dma-debug: track cache clean flag in entries
  virtio: add virtqueue_add_inbuf_cache_clean API
  vsock/virtio: fix DMA alignment for event_list
  vsock/virtio: use virtqueue_add_inbuf_cache_clean for events
  virtio_input: fix DMA alignment for evts
  virtio_scsi: fix DMA cacheline issues for events
  virtio-rng: fix DMA alignment for data buffer
  virtio_input: use virtqueue_add_inbuf_cache_clean for events
  vsock/virtio: reorder fields to reduce padding
  gpio: virtio: fix DMA alignment
  gpio: virtio: reorder fields to reduce struct padding

 Documentation/core-api/dma-api-howto.rst  | 52 ++++++++++++++
 Documentation/core-api/dma-attributes.rst |  9 +++
 drivers/char/hw_random/virtio-rng.c       |  3 +
 drivers/gpio/gpio-virtio.c                | 15 ++--
 drivers/scsi/virtio_scsi.c                | 17 +++--
 drivers/virtio/virtio_input.c             |  5 +-
 drivers/virtio/virtio_ring.c              | 83 ++++++++++++++++-------
 include/linux/dma-mapping.h               | 20 ++++++
 include/linux/virtio.h                    |  5 ++
 kernel/dma/debug.c                        | 28 ++++++--
 net/vmw_vsock/virtio_transport.c          |  8 ++-
 11 files changed, 205 insertions(+), 40 deletions(-)

-- 
MST


             reply	other threads:[~2026-01-05  8:22 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05  8:22 Michael S. Tsirkin [this message]
2026-01-05  8:22 ` [PATCH v2 01/15] dma-mapping: add __dma_from_device_group_begin()/end() Michael S. Tsirkin
2026-01-05  9:40   ` Petr Tesarik
2026-01-05 18:27   ` Marek Szyprowski
2026-01-05  8:22 ` [PATCH v2 02/15] docs: dma-api: document __dma_from_device_group_begin()/end() Michael S. Tsirkin
2026-01-05  9:48   ` Petr Tesarik
2026-01-05 18:28   ` Marek Szyprowski
2026-01-05  8:23 ` [PATCH v2 03/15] dma-mapping: add DMA_ATTR_CPU_CACHE_CLEAN Michael S. Tsirkin
2026-01-05  9:50   ` Petr Tesarik
2026-01-08 13:57   ` Marek Szyprowski
2026-01-05  8:23 ` [PATCH v2 04/15] docs: dma-api: document DMA_ATTR_CPU_CACHE_CLEAN Michael S. Tsirkin
2026-01-05  9:51   ` Petr Tesarik
2026-01-08 13:59   ` Marek Szyprowski
2026-01-05  8:23 ` [PATCH v2 05/15] dma-debug: track cache clean flag in entries Michael S. Tsirkin
2026-01-05  9:54   ` Petr Tesarik
2026-01-05 12:37     ` Michael S. Tsirkin
2026-01-05 13:40       ` Petr Tesarik
2026-01-05  8:23 ` [PATCH v2 06/15] virtio: add virtqueue_add_inbuf_cache_clean API Michael S. Tsirkin
2026-01-05  8:23 ` [PATCH v2 07/15] vsock/virtio: fix DMA alignment for event_list Michael S. Tsirkin
2026-01-08 14:04   ` Stefano Garzarella
2026-01-08 14:07     ` Michael S. Tsirkin
2026-01-08 14:18       ` Stefano Garzarella
2026-01-05  8:23 ` [PATCH v2 08/15] vsock/virtio: use virtqueue_add_inbuf_cache_clean for events Michael S. Tsirkin
2026-01-08 14:08   ` Stefano Garzarella
2026-01-05  8:23 ` [PATCH v2 09/15] virtio_input: fix DMA alignment for evts Michael S. Tsirkin
2026-01-05  8:23 ` [PATCH v2 10/15] virtio_scsi: fix DMA cacheline issues for events Michael S. Tsirkin
2026-01-05 18:19   ` Stefan Hajnoczi
2026-01-06 14:50     ` Michael S. Tsirkin
2026-01-07 16:29       ` Stefan Hajnoczi
2026-01-06 14:51     ` Michael S. Tsirkin
2026-01-05  8:23 ` [PATCH v2 11/15] virtio-rng: fix DMA alignment for data buffer Michael S. Tsirkin
2026-01-05  8:23 ` [PATCH v2 12/15] virtio_input: use virtqueue_add_inbuf_cache_clean for events Michael S. Tsirkin
2026-01-05  8:23 ` [PATCH v2 13/15] vsock/virtio: reorder fields to reduce padding Michael S. Tsirkin
2026-01-08 14:11   ` Stefano Garzarella
2026-01-08 14:17     ` Michael S. Tsirkin
2026-01-08 14:27       ` Stefano Garzarella
2026-01-08 14:32         ` Michael S. Tsirkin
2026-01-08 14:45           ` Stefano Garzarella
2026-01-05  8:23 ` [PATCH v2 14/15] gpio: virtio: fix DMA alignment Michael S. Tsirkin
2026-01-05  9:48   ` Bartosz Golaszewski
2026-01-05  8:23 ` [PATCH v2 15/15] gpio: virtio: reorder fields to reduce struct padding Michael S. Tsirkin
2026-01-05  9:49   ` Bartosz Golaszewski
2026-01-28 20:31   ` [PATCH v3 15/15] vsock/virtio: reorder fields to reduce padding Michael S. Tsirkin
2026-01-29  8:42     ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1767601130.git.mst@redhat.com \
    --to=mst@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=brgl@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=jasowang@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kraxel@redhat.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=martin.petersen@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=olivia@selenic.com \
    --cc=pabeni@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=ptesarik@suse.com \
    --cc=robin.murphy@arm.com \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xiyou.wangcong@gmail.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.