All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pauli Virtanen <pav@iki.fi>
To: linux-bluetooth@vger.kernel.org
Cc: Pauli Virtanen <pav@iki.fi>
Subject: [PATCH BlueZ v2 0/2] transport: distinguish BAP mic and playback volumes
Date: Mon,  5 Jan 2026 23:07:53 +0200	[thread overview]
Message-ID: <cover.1767647222.git.pav@iki.fi> (raw)

v2:
- Drop the bt_bap_stream_is_server() function. The direction can be
  found based on bt_bap_stream_get_dir(), which for BAP Client indicates
  the remote endpoint, and for BAP Server the local endpoint direction.

  Its return value is a bit strange for broadcast, as
  lpac BCAST_SINK -> dir BCAST_SOURCE.

***

Currently we are confusing VCP and MICP volumes.

We are also mixing up AVRCP and VCP volumes.

As microphone volumes are commonly 100% and sound server may set them,
we end up with spurious 100% playback volumes.

Fix this, and also do some cleanup of #ifdefs in the volume code.

Pauli Virtanen (2):
  transport: clean up volume set/get for A2DP and VCP
  transport: distinguish BAP mic and playback volumes

 profiles/audio/avrcp.c     |  10 +--
 profiles/audio/media.c     |   2 +-
 profiles/audio/media.h     |  10 +++
 profiles/audio/transport.c | 133 +++++++++++++++++++++----------------
 profiles/audio/transport.h |  10 +--
 profiles/audio/vcp.c       |  12 ++--
 profiles/audio/vcp.h       |  21 +++++-
 7 files changed, 121 insertions(+), 77 deletions(-)

-- 
2.52.0


             reply	other threads:[~2026-01-05 21:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 21:07 Pauli Virtanen [this message]
2026-01-05 21:07 ` [PATCH BlueZ v2 1/2] transport: clean up volume set/get for A2DP and VCP Pauli Virtanen
2026-01-05 22:04   ` transport: distinguish BAP mic and playback volumes bluez.test.bot
2026-01-05 21:07 ` [PATCH BlueZ v2 2/2] " Pauli Virtanen
2026-01-08 19:50 ` [PATCH BlueZ v2 0/2] " patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1767647222.git.pav@iki.fi \
    --to=pav@iki.fi \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.