All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
Cc: metze@samba.org, Steve French <smfrench@gmail.com>,
	Tom Talpey <tom@talpey.com>, Long Li <longli@microsoft.com>,
	Namjae Jeon <linkinjeon@kernel.org>
Subject: [PATCH 0/2] smb:client/server/smbdirect: correct value for max_fragmented_recv_size
Date: Thu,  5 Feb 2026 17:14:13 +0100	[thread overview]
Message-ID: <cover.1770307237.git.metze@samba.org> (raw)

Hi,

here is one additional fix for the credit problems
in the client, it most likely happens when using
signing on rdma: 'rdma,sec=ntlmsspi' as mount options.

The problem is that we announce a large
max_fragmented_recv_size to the server, while we
don't have enough recv buffers to hold
the largest possible fragmented message.

For now we use the same logic as we are
currently using in the server:

max_fragmented_recv_size = (recv_credit_max * max_recv_size) / 2

There's a lot to improve here, but this makes sure
we're able talk to a peer without running out of credits
while transferring a message that uses the full
max_fragmented_recv_size.

The server patch is basically just cosmetic
explaining the logic we're are using.
Note the value of smb_direct_max_fragmented_recv_size
is never really used as smb_direct_prepare
recalculates max_fragmented_recv_size.

This applies on top of ksmbd-for-next

Stefan Metzmacher (2):
  smb: client: correct value for smbd_max_fragmented_recv_size
  smb: server: correct value for smb_direct_max_fragmented_recv_size

 fs/smb/client/smbdirect.c      | 19 +++++++++++++--
 fs/smb/server/transport_rdma.c | 42 ++++++++++++++++++++++++++++++++--
 2 files changed, 57 insertions(+), 4 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-02-05 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05 16:14 Stefan Metzmacher [this message]
2026-02-05 16:14 ` [PATCH 1/2] smb: client: correct value for smbd_max_fragmented_recv_size Stefan Metzmacher
2026-02-05 16:14 ` [PATCH 2/2] smb: server: correct value for smb_direct_max_fragmented_recv_size Stefan Metzmacher
2026-02-06 15:09   ` Namjae Jeon
2026-02-06 15:15     ` Stefan Metzmacher
2026-02-07  7:27 ` [PATCH 0/2] smb:client/server/smbdirect: correct value for max_fragmented_recv_size Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1770307237.git.metze@samba.org \
    --to=metze@samba.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.