From: Philipp Hahn <phahn-oss@avm.de>
To: Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
Yuezhang Mo <yuezhang.mo@sony.com>
Cc: Philipp Hahn <phahn-oss@avm.de>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] exfat: Fix 2 issues found by static code analysis
Date: Tue, 3 Mar 2026 11:59:13 +0100 [thread overview]
Message-ID: <cover.1772534707.git.p.hahn@avm.de> (raw)
Hello,
I'm going through our list of issues found by static code analysis using Klocwork.
It found two issues worth fixing:
1. The 1st seems to be a real bug due to C's integer coercion, where the
inverted bitmask `s_blocksize` gets 0 extended.
2. The 2nd might just be a dead variable assignment, but maybe `num_clusters`
is supposed to be returned or stored elsewhere?
I hope my alaysis is correct. If yes, please apply. Thank you.
Philipp Hahn (2):
exfat: Fix bitwise operation having different size
exfat: Drop dead assignment of num_clusters
fs/exfat/dir.c | 2 +-
fs/exfat/inode.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
--
2.43.0
next reply other threads:[~2026-03-03 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 10:59 Philipp Hahn [this message]
2026-03-03 10:59 ` [PATCH] exfat: Fix bitwise operation having different size Philipp Hahn
2026-03-03 10:59 ` [PATCH] exfat: Drop dead assignment of num_clusters Philipp Hahn
2026-03-03 11:50 ` Markus Elfring
2026-03-04 8:07 ` Philipp Hahn
2026-03-04 8:40 ` exfat: Fix 2 issues found by static code analysis Markus Elfring
2026-03-04 15:12 ` Philipp Hahn
2026-03-05 10:51 ` Markus Elfring
2026-03-04 10:25 ` [PATCH] " Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1772534707.git.p.hahn@avm.de \
--to=phahn-oss@avm.de \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.