From: Stepan Ionichev <sozdayvek@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] iio: fix PM-enable leak on probe error path across 4 drivers
Date: Fri, 29 May 2026 15:44:52 +0500 [thread overview]
Message-ID: <cover.1780050609.git.sozdayvek@gmail.com> (raw)
This series fixes a class of runtime PM enable_count leaks on probe error
paths across drivers/iio/.
Each affected driver calls pm_runtime_enable() in probe and then a non-devm
registration function (typically iio_device_register()). When the
registration fails the probe returns directly without calling
pm_runtime_disable(); on subsequent probe/rebind the runtime PM tracking
complains about an unbalanced enable.
The fix is the same in each driver: replace pm_runtime_enable() with
devm_pm_runtime_enable() and drop the now-redundant pm_runtime_disable()
and pm_runtime_set_suspended() calls in the .remove() callback. The devm
action runs after .remove() and handles the teardown.
drivers/iio/adc/ti-ads1015.c was posted as a standalone patch earlier:
https://lore.kernel.org/all/20260529101011.3030-1-sozdayvek@gmail.com/
A separate follow-up will cover four more drivers (apds9960, mma8452,
pa12203001, us5182d) where the same leak exists but the probe error
path needs a goto to the existing manual cleanup label rather than a
plain return.
Stepan Ionichev (4):
iio: light: isl29028: use devm_pm_runtime_enable() to fix probe error
path
iio: light: tsl2583: use devm_pm_runtime_enable() to fix probe error
path
iio: temperature: mlx90614: use devm_pm_runtime_enable() to fix probe
error path
iio: accel: bmi088-accel: use devm_pm_runtime_enable() to fix probe
error path
drivers/iio/accel/bmi088-accel-core.c | 6 +++---
drivers/iio/light/isl29028.c | 7 +++----
drivers/iio/light/tsl2583.c | 6 +++---
drivers/iio/temperature/mlx90614.c | 6 +++---
4 files changed, 12 insertions(+), 13 deletions(-)
base-commit: 7cb1c5b32a2bfde961fff8d5204526b609bcb30a
--
2.43.0
next reply other threads:[~2026-05-29 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 10:44 Stepan Ionichev [this message]
2026-05-29 10:44 ` [PATCH 1/4] iio: light: isl29028: use devm_pm_runtime_enable() to fix probe error path Stepan Ionichev
2026-05-29 10:44 ` [PATCH 2/4] iio: light: tsl2583: " Stepan Ionichev
2026-05-29 10:44 ` [PATCH 3/4] iio: temperature: mlx90614: " Stepan Ionichev
2026-05-29 10:44 ` [PATCH 4/4] iio: accel: bmi088-accel: " Stepan Ionichev
2026-05-29 11:11 ` [PATCH 0/4] iio: fix PM-enable leak on probe error path across 4 drivers Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1780050609.git.sozdayvek@gmail.com \
--to=sozdayvek@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.