From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 0/2] btrfs: minor fixes and cleanups on direct IO path
Date: Mon, 8 Jun 2026 12:32:14 +0930 [thread overview]
Message-ID: <cover.1780873489.git.wqu@suse.com> (raw)
[CHANGELOG]
v2:
- Drop the first 2 patches
The problem with APPEND NOWAIT direct writes needs more consideration.
If short writes happened for APPEND NOWAIT write, there are more
factors to consider.
Firstly we should return -EGAIN so that the caller can retry in a
blocking way.
Secondly we should fully revert what has been written so that isize is
not increased.
For the OE conflicts I have not yet hit with upstream, so it should be
something wrong in my previous direct locking changes.
There are several small problems inside the direct IO code:
- Duplicated btrfs_dio_data::submitted
The iomap_end() callback has @written parameter which provides the
same value.
Fixed in the third patch.
- Badly structured btrfs_dio_iomap_end()
Refactored in the last patch.
Qu Wenruo (2):
btrfs: remove btrfs_dio_data::submitted
btrfs: refactor btrfs_dio_iomap_end()
fs/btrfs/direct-io.c | 131 ++++++++++++++++++++++---------------------
1 file changed, 66 insertions(+), 65 deletions(-)
--
2.54.0
next reply other threads:[~2026-06-08 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 3:02 Qu Wenruo [this message]
2026-06-08 3:02 ` [PATCH v2 1/2] btrfs: remove btrfs_dio_data::submitted Qu Wenruo
2026-06-08 3:02 ` [PATCH v2 2/2] btrfs: refactor btrfs_dio_iomap_end() Qu Wenruo
2026-06-08 11:25 ` [PATCH v2 0/2] btrfs: minor fixes and cleanups on direct IO path Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1780873489.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.