All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chinna Mopurigari Naveen Kumar Reddy <naveen.reddy@ftdichip.com>
To: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arun Pappan <arun.pappan@ftdichip.com>
Subject: [PATCH v3 0/2] USB: serial: ftdi_sio: latency_timer reliability fixes
Date: Tue, 23 Jun 2026 16:03:19 +0800	[thread overview]
Message-ID: <cover.1782201674.git.naveen.reddy@ftdichip.com> (raw)
In-Reply-To: <cover.1782121274.git.naveen.reddy@ftdichip.com>

Two independent correctness fixes for ftdi_sio:

  1. Retry transient errors (-ETIMEDOUT / -EPIPE / -EPROTO) on
     chip-side control transfers so that a single transient USB hiccup
     under bus load does not fail an otherwise-healthy one-shot
     configuration (e.g. a latency_timer sysfs write) back to
     userspace as -EIO.

  2. Make an explicit sysfs write to latency_timer authoritative so
     that a userspace write is not silently clamped to 1 by the
     ASYNC_LOW_LATENCY tty flag left set by an earlier TIOCSSERIAL
     (setserial(8), libftdi, certain tcsetattr paths).

Changes since v2:
  - patch 2/2: lower the override notice from dev_info() to dev_dbg()
    so the driver stays quiet in normal operation (Greg Kroah-Hartman).

Changes since v1:
  - Dropped the urb_defer_timer_ns and low_latency_defer_ns
    module-parameter patches, which addressed DMA-channel starvation on
    a host controller that does not enforce DMA-channel fairness.  As
    Greg Kroah-Hartman noted, that belongs in the host controller
    driver, not as a per-driver workaround in ftdi_sio.
  - Dropped the per-port low_latency sysfs attribute and its
    serialisation fix, which depended on the hrtimer infrastructure
    introduced by the dropped patch and have no standalone purpose
    without it.

Earlier postings:
  [v1] https://lore.kernel.org/linux-usb/cover.1781744946.git.naveen.reddy@ftdichip.com/
  [v2] https://lore.kernel.org/linux-usb/cover.1782121274.git.naveen.reddy@ftdichip.com/

Chinna Mopurigari Naveen Kumar Reddy (2):
  USB: serial: ftdi_sio: retry transient errors on chip-side control
    transfers
  USB: serial: ftdi_sio: make explicit latency_timer sysfs write
    authoritative

 drivers/usb/serial/ftdi_sio.c | 65 +++++++++++++++++++++++++++++++----
 1 file changed, 58 insertions(+), 7 deletions(-)


base-commit: ba3e43a9e601636f5edb54e259a74f96ca3b8fd8
-- 
2.43.0


  parent reply	other threads:[~2026-06-23  8:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22  7:38 [PATCH 0/6] USB: serial: ftdi_sio: configurable read-URB defer, per-port low_latency, latency_timer reliability Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  7:38 ` [PATCH 1/6] USB: serial: ftdi_sio: add configurable inter-batch defer for read URBs Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  8:51   ` Greg Kroah-Hartman
2026-06-22  8:52   ` Greg Kroah-Hartman
2026-06-22  9:05     ` Chinna Mopurigari Naveen Kumar Reddy (FTDI-SG)
2026-06-22  9:27       ` Greg Kroah-Hartman
2026-06-22  9:43         ` Chinna Mopurigari Naveen Kumar Reddy (FTDI-SG)
2026-06-22  7:38 ` [PATCH 2/6] USB: serial: ftdi_sio: retry transient errors on chip-side control transfers Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  7:38 ` [PATCH 3/6] USB: serial: ftdi_sio: make explicit latency_timer sysfs write authoritative Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  7:38 ` [PATCH 4/6] USB: serial: ftdi_sio: add per-port low_latency sysfs attribute Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  7:38 ` [PATCH 5/6] USB: serial: ftdi_sio: serialise low_latency toggle against read_bulk_callback Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  7:38 ` [PATCH 6/6] USB: serial: ftdi_sio: pace low_latency ports with low_latency_defer_ns Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  9:43 ` [PATCH v2 0/2] USB: serial: ftdi_sio: latency_timer reliability fixes Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  9:43   ` [PATCH v2 1/2] USB: serial: ftdi_sio: retry transient errors on chip-side control transfers Chinna Mopurigari Naveen Kumar Reddy
2026-06-22  9:43   ` [PATCH v2 2/2] USB: serial: ftdi_sio: make explicit latency_timer sysfs write authoritative Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 10:19     ` Greg Kroah-Hartman
2026-06-23  0:20       ` Chinna Mopurigari Naveen Kumar Reddy (FTDI-SG)
2026-06-23  8:03   ` Chinna Mopurigari Naveen Kumar Reddy [this message]
2026-06-23  8:03     ` [PATCH v3 1/2] USB: serial: ftdi_sio: retry transient errors on chip-side control transfers Chinna Mopurigari Naveen Kumar Reddy
2026-06-23  8:03     ` [PATCH v3 2/2] USB: serial: ftdi_sio: make explicit latency_timer sysfs write authoritative Chinna Mopurigari Naveen Kumar Reddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1782201674.git.naveen.reddy@ftdichip.com \
    --to=naveen.reddy@ftdichip.com \
    --cc=arun.pappan@ftdichip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.