All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mateusz Nowicki <mateusz.nowicki@posteo.net>
To: qemu-devel@nongnu.org
Cc: "Mateusz Nowicki" <mateusz.nowicki@posteo.net>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Dr . David Alan Gilbert" <dave@treblig.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Keith Busch" <kbusch@kernel.org>,
	"Jesper Devantier" <foss@defmacro.it>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Eric Blake" <eblake@redhat.com>,
	qemu-block@nongnu.org
Subject: [PATCH v4 0/2] hw/nvme: add monitor commands for inspecting state
Date: Tue, 30 Jun 2026 11:52:30 +0000	[thread overview]
Message-ID: <cover.1782819251.git.mateusz.nowicki@posteo.net> (raw)

Add two HMP commands for inspecting emulated NVMe controllers from
the QEMU monitor without attaching gdb to the QEMU process:

  - 'info nvme'        - per-controller summary (PCI, identify
                         fields, CC/CSTS/AQA, queue counts)
  - 'info nvme-queues' - per-queue listing of admin and I/O SQ/CQ
                         (size, head/tail, PRP1, doorbell offset,
                         phase tag)

Useful for verifying queue setup, doorbell rings, AERs held in the
admin SQ and similar driver/controller interaction details from a
running QEMU monitor.

Changes in v4:
  - Drop the v3 attempt to gate the new commands with
    'if': 'CONFIG_NVME_PCI'.  CONFIG_NVME_PCI is a device symbol and
    is poisoned in common code, so the generated qapi-introspect.c
    failed to build (reported by Klaus Jensen).  Instead the x-query
    commands stay unconditional and hw/nvme/monitor-stub.c provides
    qmp_x_query_nvme[_queues]() stubs, built when CONFIG_NVME_PCI is
    not set, so targets without NVMe (e.g. riscv64-softmmu) link.

Changes in v3:
  - hw/nvme/meson.build: keep the source file list alphabetically
    sorted (Markus).

Changes in v2:
  - hw/nvme/meson.build: add the missing trailing newline (Markus).
  - Pick up Acked-by tags from Dr. David Alan Gilbert and Markus
    Armbruster on both patches.

v3: https://lore.kernel.org/qemu-devel/20260626112116.7621-1-mateusz.nowicki@posteo.net/
v2: https://lore.kernel.org/qemu-devel/cover.1778694320.git.mateusz.nowicki@posteo.net/
v1: https://lore.kernel.org/qemu-devel/cover.1778409416.git.mateusz.nowicki@posteo.net/

Mateusz Nowicki (2):
  hw/nvme: add 'info nvme' HMP command
  hw/nvme: add 'info nvme-queues' HMP command

 hmp-commands-info.hx   |  28 +++++++++
 hw/nvme/meson.build    |   4 +-
 hw/nvme/monitor-stub.c |  21 +++++++
 hw/nvme/monitor.c      | 139 +++++++++++++++++++++++++++++++++++++++++
 qapi/machine.json      |  34 ++++++++++
 5 files changed, 225 insertions(+), 1 deletion(-)
 create mode 100644 hw/nvme/monitor-stub.c
 create mode 100644 hw/nvme/monitor.c

-- 
2.53.0



             reply	other threads:[~2026-06-30 11:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 11:52 Mateusz Nowicki [this message]
2026-06-30 11:52 ` [PATCH v4 1/2] hw/nvme: add 'info nvme' HMP command Mateusz Nowicki
2026-06-30 11:52 ` [PATCH v4 2/2] hw/nvme: add 'info nvme-queues' " Mateusz Nowicki
2026-07-02 16:38 ` [PATCH v4 0/2] hw/nvme: add monitor commands for inspecting state Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1782819251.git.mateusz.nowicki@posteo.net \
    --to=mateusz.nowicki@posteo.net \
    --cc=armbru@redhat.com \
    --cc=dave@treblig.org \
    --cc=eblake@redhat.com \
    --cc=foss@defmacro.it \
    --cc=its@irrelevant.dk \
    --cc=kbusch@kernel.org \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.