All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Bingham <jbingham@gmail.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, brauner@kernel.org,
	jkoolstra@xs4all.nl, jack@suse.cz,
	Jeremy Bingham <jbingham@gmail.com>
Subject: [PATCH 0/2] minix: modernize function declarations and eliminating some magic numbers
Date: Mon,  6 Jul 2026 11:22:42 -0700	[thread overview]
Message-ID: <cover.1783360491.git.jbingham@gmail.com> (raw)

Another set of minix patches fixing issues that I noticed while working
on other things. The various dirsize and namelen values being set in
minix_fill_super() in inode.c, which vary depending on the versions of
the minix filesystem and how it was created, were being set as magic
numbers. The function declarations in minix.h were also a mix of current
and historic kernel coding standards, where some function declarations
had arguments with types and names while others had only types. This
became an annoyance when updating minix.h because checkpatch.pl would
gripe about improper function declarations.

Create and use #defines for the various dirsize and namelen values in
minix_fill_super, and modernize the function declarations in minix.h.

Both patches have been tested by mounting and performing file operations
against v1, v2, and v3 minix filesystem volumes. Neither of them have
any functional changes.

Jeremy Bingham (2):
  minix: define constants for dirsize and namelen
  minix: modernize function declarations in minix.h

 fs/minix/inode.c    | 20 ++++++------
 fs/minix/itree_v1.c |  2 +-
 fs/minix/itree_v2.c |  2 +-
 fs/minix/minix.h    | 78 ++++++++++++++++++++++++++++++---------------
 4 files changed, 65 insertions(+), 37 deletions(-)

-- 
2.47.3


             reply	other threads:[~2026-07-06 18:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 18:22 Jeremy Bingham [this message]
2026-07-06 18:22 ` [PATCH 1/2] minix: define constants for dirsize and namelen Jeremy Bingham
2026-07-06 20:47   ` Jori Koolstra
2026-07-06 18:22 ` [PATCH 2/2] minix: modernize function declarations in minix.h Jeremy Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1783360491.git.jbingham@gmail.com \
    --to=jbingham@gmail.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=jkoolstra@xs4all.nl \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.