From: Reinette Chatre <reinette.chatre@intel.com>
To: tony.luck@intel.com, james.morse@arm.com, Dave.Martin@arm.com,
babu.moger@amd.com, bp@alien8.de, tglx@linutronix.de,
dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, ben.horgan@arm.com,
fustini@kernel.org, fenghuay@nvidia.com, peternewman@google.com,
yu.c.chen@intel.com, linux-kernel@vger.kernel.org,
patches@lists.linux.dev, reinette.chatre@intel.com
Subject: [PATCH v7 0/7] x86,fs/resctrl: Fix long-standing issues
Date: Mon, 13 Jul 2026 10:39:36 -0700 [thread overview]
Message-ID: <cover.1783963505.git.reinette.chatre@intel.com> (raw)
v6: https://lore.kernel.org/lkml/cover.1783377598.git.reinette.chatre@intel.com/
v5: https://lore.kernel.org/lkml/cover.1781029125.git.reinette.chatre@intel.com/
v4: https://lore.kernel.org/lkml/cover.1780456704.git.reinette.chatre@intel.com/
v3: https://lore.kernel.org/lkml/cover.1779476724.git.reinette.chatre@intel.com/
v2: https://lore.kernel.org/lkml/20260515193944.15114-1-tony.luck@intel.com/
v1: https://lore.kernel.org/all/20260508182143.14592-1-tony.luck@intel.com/
While reviewing the AET series [1] Sashiko reported a deadlock during mount,
and a use-after-free when an L3 domain is removed during CPU offline. More issues
were uncovered as fixes were developed and reviewed. While the goal is to
fix all issues the races surrounding pseudo-locked regions are not yet
solved and have been removed from this series (last appearance was in V3 of
this series).
Applies against v7.2-rc3.
Changes since V6:
- Drop first three patches that are in v7.2-rc3.
- Remove extra blank lines. (Tony)
- No functional changes.
Changes since V5:
- Drop patch #1 (x86,fs/resctrl: Prevent out-of-bounds access while offlining
CPU when SNC enabled) that can be found in v7.2-rc2.
- Re-order remaining patches so that stable candidate patches are at
beginning of series. The stable candidates are:
Patch 1: fs/resctrl: Free mon_data structures on rdt_get_tree() failure
Patch 2: fs/resctrl: Fix use-after-free during unmount
Patch 3: fs/resctrl: Fix double-add of pseudo-locked region's RMID to free list
- To support the backporting to stable patch #1 adds a forward declaration
that is removed in patch #5 that moves the actual functions to avoid too many
forward declarations.
- The end result of changes since v5: v6 net changes are identical to V5
changes.
Changes since V4:
- Add new fix to prevent out-of-bouds read when SNC is enabled and domain
with busy RMID goes offline.
- Add substitute for "is domain going offline" check to workers to avoid
reading any event counters on soon-to-be-offline domain since its
cpu_mask is empty and reading an event counter on an SNC enabled system
depends on knowing a CPU associated with the domain.
Changes since V3:
- Drop majority of pseudo-locking fixes, only keep the double free/double
list add fix.
- Add patch to help document safe RCU list traversal.
- See individual patches for detailed changes.
[1] https://sashiko.dev/#/patchset/20260429184858.36423-1-tony.luck%40intel.com
Reinette Chatre (6):
x86,fs/resctrl: Document safe RCU list traversal
fs/resctrl: Fix deadlock on errors during mount
fs/resctrl: Prevent use-after-free in rdtgroup_kn_put()
fs/resctrl: Prevent deadlock and use-after-free in info file handlers
x86/resctrl: Ensure domain fully initialized before placed on RCU list
fs/resctrl: Fix UAF from worker threads when domains are removed
Tony Luck (1):
fs/resctrl: Move functions to avoid forward references in subsequent
fixes
arch/x86/kernel/cpu/resctrl/core.c | 18 +-
arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 4 +-
arch/x86/kernel/cpu/resctrl/intel_aet.c | 5 +-
arch/x86/kernel/cpu/resctrl/monitor.c | 2 +-
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 4 +-
fs/resctrl/ctrlmondata.c | 50 +-
fs/resctrl/internal.h | 3 +-
fs/resctrl/monitor.c | 131 ++--
fs/resctrl/pseudo_lock.c | 2 +-
fs/resctrl/rdtgroup.c | 858 +++++++++++++---------
10 files changed, 660 insertions(+), 417 deletions(-)
base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
--
2.54.0
next reply other threads:[~2026-07-13 17:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 17:39 Reinette Chatre [this message]
2026-07-13 17:39 ` [PATCH v7 1/7] x86,fs/resctrl: Document safe RCU list traversal Reinette Chatre
2026-07-13 17:39 ` [PATCH v7 2/7] fs/resctrl: Move functions to avoid forward references in subsequent fixes Reinette Chatre
2026-07-13 17:39 ` [PATCH v7 3/7] fs/resctrl: Fix deadlock on errors during mount Reinette Chatre
2026-07-13 17:39 ` [PATCH v7 4/7] fs/resctrl: Prevent use-after-free in rdtgroup_kn_put() Reinette Chatre
2026-07-13 17:39 ` [PATCH v7 5/7] fs/resctrl: Prevent deadlock and use-after-free in info file handlers Reinette Chatre
2026-07-13 17:39 ` [PATCH v7 6/7] x86/resctrl: Ensure domain fully initialized before placed on RCU list Reinette Chatre
2026-07-13 17:39 ` [PATCH v7 7/7] fs/resctrl: Fix UAF from worker threads when domains are removed Reinette Chatre
2026-07-13 18:29 ` [PATCH v7 0/7] x86,fs/resctrl: Fix long-standing issues Borislav Petkov
2026-07-13 20:47 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1783963505.git.reinette.chatre@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=fustini@kernel.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.