From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68246C55184 for ; Tue, 4 Aug 2026 03:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=wDGsIohfeV98fyRDJDwZIGZioU3ZkExJNiulZ+SgHGg=; b=mr1Wiojdu4nKthTRmUI9M2yM/t +HGYXgE0RkCreEkHqQqvGGXgFwhV1WjP/3yCNHvmHUS+bzkkBbhmiPsn1Ga63NjBRzcTnfLPw5wP1 JNt1feJ2i1uz/dJIfzhR96+KLE2r0NN/5fi/yBX2ZkB3Mt2/rH94u2IM/5CQWT06Uw34Xzk+WAksE B6GQajfDAD1VPmAxWhM2Uj8c99YosxLhvsyqvjMiUAvexJaJWi947W7zKvdBDVMyebNnHRV2v9iHt nbsIBazfG3++oIQkSIXJJ5vpmkI1Wtr2mi2R69BvKl2zsC61qj6kmiKJssyyTcyeeaEmqWwpVr0Aj F/H+WBdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wr5YB-00000000tPv-13Qf; Tue, 04 Aug 2026 03:10:43 +0000 Received: from pidgin.makrotopia.org ([2a07:2ec0:3002::65]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wr5Y8-00000000tOE-49c7; Tue, 04 Aug 2026 03:10:42 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1wr5Xp-00000000448-3OQV; Tue, 04 Aug 2026 03:10:21 +0000 Date: Tue, 4 Aug 2026 04:10:17 +0100 From: Daniel Golle To: "Chester A. Unal" , Daniel Golle , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Alexander Couzens , Heiner Kallweit , Russell King , Russell King , Sean Wang , Landen Chao , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v2 0/6] net: dsa: mt7530: fix remaining swallowed MDIO access errors Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260803_201041_025544_E70A1965 X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The original series, "net: dsa: mt7530: fix swallowed MDIO read errors", landed on net as its v1 [1] just before its v2 [2] was sent. This series started from the fixes in that original v2 which its v1 had not already carried: the two standalone patches that original v2 grew from the Sashiko AI review of its v1 (the mtk-lynxi read check and the regmap IRQ serialization), plus, split into patches of their own, the companion fixes original v2 had folded into the already-applied patches -- the unchecked bus->read() in core_rmw() and the unchecked PHY_IAC command writes in the MT7531 indirect PHY access functions. The Sashiko AI review of this series' own v1 [3] then flagged two more swallowed MDIO errors of the same kind, added here as patches of their own: the unchecked CORE_PLL_GROUP4 read-modify-write in mt7531_setup(), and the unchecked ATC/VTCR command-register writes in mt7530_fdb_cmd() and mt7530_vlan_cmd(). The remaining non-fix changes from the original v2, dropping a redundant read-back and improving the poll failure messages, will follow via net-next. Changes in this series (v2), relative to its v1 [3]: * patch 1: also report the link as down (state->link = false) on the failed-read path; phylink presets state->link, so the previous bare return reported a failed read as link-up (Sashiko AI review). Kept Andrew's Reviewed-by given the small, in-spirit change -- please re-confirm. * new patch 4: check the CORE_PLL_GROUP4 read-modify-write in mt7531_setup(), the call site exposed once patch 3 makes the MT7531 indirect c45 access propagate command-write failures. * new patch 5: propagate MT7530_ATC / MT7530_VTCR command-register write errors in mt7530_fdb_cmd() and mt7530_vlan_cmd() instead of polling a BUSY bit that a failed write never set. * collected Reviewed-by: Andrew Lunn on patches 1-3 and 6. [1] https://lore.kernel.org/netdev/cover.1785213071.git.daniel@makrotopia.org/ [2] https://lore.kernel.org/netdev/cover.1785368701.git.daniel@makrotopia.org/ [3] https://lore.kernel.org/netdev/cover.1785427248.git.daniel@makrotopia.org/ Daniel Golle (6): net: pcs: mtk-lynxi: check regmap reads in mtk_pcs_lynxi_get_state() net: dsa: mt7530: check bus->read() error in core_rmw() net: dsa: mt7530: error out on failed PHY_IAC command writes net: dsa: mt7530: check CORE_PLL_GROUP4 access in mt7531_setup() net: dsa: mt7530: check command register writes in fdb and vlan cmd net: dsa: mt7530: serialize the regmap IRQ chip like every other user drivers/net/dsa/mt7530.c | 86 +++++++++++++++++++++++++++------ drivers/net/pcs/pcs-mtk-lynxi.c | 7 ++- 2 files changed, 75 insertions(+), 18 deletions(-) base-commit: af39eb111ce6b5eba9c08513b62c4868eb7e7fd5