From: Benjamin Coddington <ben.coddington@hammerspace.com>
To: Trond Myklebust <trondmy@kernel.org>, Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/3] pNFS/flexfiles: mirror instance error handling
Date: Thu, 13 Aug 2026 14:07:12 -0400 [thread overview]
Message-ID: <cover.1786636529.git.bcodding@hammerspace.com> (raw)
When a flexfiles data server fails, the client marks the layout for return
and cancels the layout segment's in-flight I/O. ff_layout_cancel_io()
cancels I/O to every mirror instance rather than just the failed one, and
cancelling a request that has already been transmitted does not stop the
data server from executing it. Those writes may complete after the client
has sent its LAYOUTRETURN, and the metadata server will see writes to a file
for which no write layout is outstanding.
Patch 1 reports the operation the client was preparing to send when a
data server connection fails, instead of OP_ILLEGAL.
Patches 2 and 3 let a layout driver cancel I/O to a single device, and
pass the failed device down from the flexfiles error paths, so that I/O
to the remaining mirrors drains before the LAYOUTRETURN is sent.
Layout recalls that set clora_changed, bulk returns and revocations are
unchanged: they continue to cancel I/O to every device.
Benjamin Coddington (3):
NFSv4/flexfiles: report the intended opnum when DS connection setup
fails
pNFS: allow layout drivers to cancel I/O to a single device
NFSv4/flexfiles: only cancel I/O to a failed mirror instance
fs/nfs/blocklayout/blocklayout.c | 6 +++--
fs/nfs/callback_proc.c | 2 +-
fs/nfs/filelayout/filelayout.c | 4 +--
fs/nfs/flexfilelayout/flexfilelayout.c | 29 ++++++++++++--------
fs/nfs/flexfilelayout/flexfilelayout.h | 2 +-
fs/nfs/flexfilelayout/flexfilelayoutdev.c | 17 +++++++-----
fs/nfs/pnfs.c | 32 ++++++++++++++---------
fs/nfs/pnfs.h | 14 ++++++----
8 files changed, 64 insertions(+), 42 deletions(-)
--
2.53.0
next reply other threads:[~2026-08-13 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 18:07 Benjamin Coddington [this message]
2026-08-13 18:07 ` [PATCH 1/3] NFSv4/flexfiles: report the intended opnum when DS connection setup fails Benjamin Coddington
2026-08-13 18:07 ` [PATCH 2/3] pNFS: allow layout drivers to cancel I/O to a single device Benjamin Coddington
2026-08-13 18:07 ` [PATCH 3/3] NFSv4/flexfiles: only cancel I/O to a failed mirror instance Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1786636529.git.bcodding@hammerspace.com \
--to=ben.coddington@hammerspace.com \
--cc=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.