All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junjie Cao <junjie.cao@intel.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Feifan Qian" <bea1e@proton.me>
Subject: [PATCH 0/4] hw/usb/hcd-xhci: two isoch fixes with qtests
Date: Mon, 21 Sep 2026 13:46:28 +0800	[thread overview]
Message-ID: <cover.1789968699.git.junjie.cao@intel.com> (raw)

Two xHCI bugs from the issue tracker, each with a qtest.

The interval mask is 32 bits wide, so once MFINDEX passes 2^32 isoch TDs
with SIA are no longer held until the next interval boundary. This
matches #3973: onset after 6.2 days of uptime, cleared by re-binding the
controller in the guest.

A guest can declare a non-isoch endpoint as isoch and hit an assertion
when the device NAKs (#3886). #544 is the same assertion, reached from
the kick timer as in patch 4. Its reproducer from 2021 no longer
triggers on master, so it is not tagged.

Both tests fail on master (c1c18d1e64). Tested on x86_64 with an
ASan/UBSan build: usb-hcd-xhci-test, usb-hcd-ehci-test and
usb-hcd-uhci-test pass. The new tests skip on ppc64.

Junjie Cao (4):
  hw/usb/hcd-xhci: fix interval alignment after MFINDEX passes 2^32
  hw/usb/hcd-xhci: don't assert on NAK when retrying an isoch transfer
  tests/qtest/usb-hcd-xhci: test isoch pacing with MFINDEX above 2^32
  tests/qtest/usb-hcd-xhci: test isoch endpoint type mismatch

 hw/usb/hcd-xhci.c               |  33 +---
 tests/qtest/usb-hcd-xhci-test.c | 318 ++++++++++++++++++++++++++++++++
 2 files changed, 328 insertions(+), 23 deletions(-)


base-commit: c1c18d1e640b64292859ce9f30f3c344edfb0294
-- 
2.43.0



             reply	other threads:[~2026-09-21  5:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  5:46 Junjie Cao [this message]
2026-09-21  5:46 ` [PATCH 1/4] hw/usb/hcd-xhci: fix interval alignment after MFINDEX passes 2^32 Junjie Cao
2026-09-22  4:56   ` Philippe Mathieu-Daudé
2026-09-21  5:46 ` [PATCH 2/4] hw/usb/hcd-xhci: don't assert on NAK when retrying an isoch transfer Junjie Cao
2026-09-22 11:28   ` Thomas Huth
2026-09-21  5:46 ` [PATCH 3/4] tests/qtest/usb-hcd-xhci: test isoch pacing with MFINDEX above 2^32 Junjie Cao
2026-09-22  4:57   ` Philippe Mathieu-Daudé
2026-09-21  5:46 ` [PATCH 4/4] tests/qtest/usb-hcd-xhci: test isoch endpoint type mismatch Junjie Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1789968699.git.junjie.cao@intel.com \
    --to=junjie.cao@intel.com \
    --cc=bea1e@proton.me \
    --cc=farosas@suse.de \
    --cc=kraxel@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.