[PATCH v4 00/54] scsi: Enable context analysis for most drivers

[Bart Van Assche <bvanassche@acm.org>]

This patch series enables lock context analysis for all SCSI drivers in the
drivers/scsi/ directory except scsi_debug. The advantages are as follows:
 - The compiler (only Clang) verifies whether the lock and unlock calls match
   what has been declared via __must_hold(), __acquires() or __releases().
   This is useful for catching locking bugs in error paths.
 - Support for __guarded_by() is enabled. If a member variable is annotated
   with __guarded_by(lock), the compiler will issue a warning if that member
   variable is accessed without holding 'lock'.

Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v3:
 - Dropped the SCSI core and UFS patches (merged upstream in Linux 7.3).
 - Replaced __no_context_analysis with __context_unsafe(/*reason*/) across
   drivers with conditional locking (aacraid, ips, libfc, lpfc, mvsas, qedi,
   qla2xxx, qla4xxx).
 - Passed struct pointers directly to functions called with locks held instead
   of dereferencing or using __assume_ctx_lock():
   * BusLogic: Pass struct Scsi_Host * directly to multiple functions.
   * libiscsi: Pass struct iscsi_session * directly to functions requiring
     session locks and update callers in be2iscsi, bnx2i, cxgbi, libiscsi,
     libiscsi_tcp, qedi, qla4xxx, and iser.
   * bnx2fc: Pass tgt directly to several functions.
   * csiostor: Pass struct csio_hw * directly to cleanup and abort functions.
   * fnic: Pass struct fnic_iport_s * and struct fnic * directly.
   * ipr: Pass struct Scsi_Host * directly to error handling functions.
   * qla1280: Pass struct Scsi_Host * directly to wait/error functions.
   * NCR5380: Pass struct NCR5380_hostdata * directly to NCR5380_select()
     and NCR5380_information_transfer().
   * fcoe: Pass struct fcoe_ctlr * directly to functions called with locks
     held.
 - scsi: ipr: Added patch to simplify ipr_eh_abort() by deriving the host
   pointer once (detected by Sashiko).
 - scsi: smartpqi: Fixed missing ampersands (&ctrl_info->...), documented
   locking requirements with __acquires(), __releases(), and __cond_releases(),
   and suppressed complaints with __acquire() where mutex usage is irregular.
 - scsi: cxgbi: Added __assume_ctx_lock(&conn->session->back_lock) with a
   TODO comment documenting missing locking around iscsi_itt_to_ctask().
 - scsi: libfc: Added __must_hold annotations for discovery and FCP functions.
 - scsi: ibmvscsi_tgt: Added __must_hold(&vscsi->intr_lock) annotations.
 - scsi: pm8001: Added Acked-by from Jack Wang.
 - Consolidated preparation and enabling patches for aic7xxx, be2iscsi, and
   bnx2i.
 - Moved the scsi_debug changes into a separate patch series.
 - Dropped megaraid / megaraid_sas patches from this series. These will be
   reposted later.
 - Added patch "scsi: drivers: Enable lock context analysis" as the final patch
   to enable CONTEXT_ANALYSIS := y in drivers/scsi/Makefile (excluding
   scsi_debug).

Changes compared to v2:
 - Added patch "scsi: core: Pass the SCSI host pointer directly".
 - Corrected several annotations that had missing or extra ampersands (&).
 - Reduced the number of __assume_ctx_lock() statements.

Changes compared to v1:
 - Split patch "Enable lock context analysis" into one patch per driver.


Bart Van Assche (54):
  PCI: Convert to_pci_dev() into an inline function
  scsi: sg: Prepare for enabling lock context analysis
  scsi: st: Prepare for enabling lock context analysis
  scsi: BusLogic: Pass the host pointer directly to several functions
  scsi: BusLogic: Prepare for enabling lock context analysis
  scsi: NCR5380: Prepare for enabling lock context analysis
  scsi: aacraid: Enable lock context analysis
  scsi: aha152x: Prepare for enabling lock context analysis
  scsi: aic7xxx: Enable lock context analysis
  scsi: aic94xx: Enable lock context analysis
  scsi: arcmsr: Enable lock context analysis
  scsi: libiscsi: Pass the session pointer directly to several functions
  scsi: libiscsi: Prepare for enabling lock context analysis
  scsi: be2iscsi: Enable lock context analysis
  scsi: cxgbi: Enable lock context analysis
  scsi: bfa: Enable lock context analysis
  scsi: bnx2fc: Pass tgt directly to several functions
  scsi: bnx2fc: Enable lock context analysis
  scsi: bnx2i: Enable lock context analysis
  scsi: csiostor: Pass the hw pointer directly to several functions
  scsi: csiostor: Enable lock context analysis
  scsi: elx: Enable lock context analysis
  scsi: esas2r: Enable lock context analysis
  scsi: fcoe: Enable lock context analysis
  scsi: fnic: Pass pointers directly to several functions
  scsi: fnic: Enable lock context analysis
  scsi: hisi_sas: Enable lock context analysis
  scsi: hpsa: Prepare for enabling lock context analysis
  scsi: ibmvscsi: Enable lock context analysis
  scsi: ibmvscsi_tgt: Enable lock context analysis
  scsi: ipr: Simplify ipr_eh_abort()
  scsi: ipr: Pass the host pointer directly to several functions
  scsi: ipr: Prepare for enabling lock context analysis
  scsi: ips: Prepare for enabling lock context analysis
  scsi: isci: Enable lock context analysis
  scsi: libfc: Enable lock context analysis
  scsi: libsas: Prepare for enabling lock context analysis
  scsi: libsas: Enable lock context analysis
  scsi: lpfc: Prepare for enabling lock context analysis
  scsi: mpt3sas: Enable lock context analysis
  scsi: mvsas: Enable lock context analysis
  scsi: pcmcia: Enable lock context analysis
  scsi: pm8001: Enable lock context analysis
  scsi: qedf: Enable lock context analysis
  scsi: qedi: Enable lock context analysis
  scsi: qla1280: Pass the host pointer directly to several functions
  scsi: qla1280: Prepare for enabling lock context analysis
  scsi: qla2xxx: Enable lock context analysis
  scsi: qla4xxx: Enable lock context analysis
  scsi: iSCSI transport: Prepare for enabling lock context analysis
  scsi: smartpqi: Enable lock context analysis
  scsi: snic: Enable lock context analysis
  scsi: sym53c8xx_2: Enable lock context analysis
  scsi: drivers: Enable lock context analysis

 drivers/infiniband/ulp/iser/iser_initiator.c |   3 +-
 drivers/scsi/BusLogic.c                      |  99 ++++---
 drivers/scsi/BusLogic.h                      |   3 +-
 drivers/scsi/Makefile                        |  25 +-
 drivers/scsi/NCR5380.c                       |  19 +-
 drivers/scsi/NCR5380.h                       |   5 +-
 drivers/scsi/aacraid/Makefile                |   2 +
 drivers/scsi/aacraid/commctrl.c              |   1 +
 drivers/scsi/aacraid/commsup.c               |   3 +
 drivers/scsi/aha152x.c                       |   4 +-
 drivers/scsi/aic7xxx/Makefile                |   2 +
 drivers/scsi/aic7xxx/aic79xx_osm.h           |   2 +
 drivers/scsi/aic7xxx/aic7xxx_osm.h           |   2 +
 drivers/scsi/aic94xx/Makefile                |   2 +
 drivers/scsi/arcmsr/Makefile                 |   2 +
 drivers/scsi/be2iscsi/Makefile               |   2 +
 drivers/scsi/be2iscsi/be_main.c              |  18 +-
 drivers/scsi/bfa/Makefile                    |   3 +
 drivers/scsi/bnx2fc/Makefile                 |   3 +
 drivers/scsi/bnx2fc/bnx2fc.h                 |   9 +-
 drivers/scsi/bnx2fc/bnx2fc_els.c             |  27 +-
 drivers/scsi/bnx2fc/bnx2fc_hwi.c             |   2 +-
 drivers/scsi/bnx2fc/bnx2fc_io.c              |  15 +-
 drivers/scsi/bnx2fc/bnx2fc_tgt.c             |   2 +-
 drivers/scsi/bnx2i/Makefile                  |   3 +
 drivers/scsi/bnx2i/bnx2i_hwi.c               |  45 ++--
 drivers/scsi/bnx2i/bnx2i_iscsi.c             |   1 +
 drivers/scsi/csiostor/Makefile               |   2 +
 drivers/scsi/csiostor/csio_attr.c            |   4 +-
 drivers/scsi/csiostor/csio_hw.c              |  20 +-
 drivers/scsi/csiostor/csio_lnode.c           |   3 +
 drivers/scsi/csiostor/csio_rnode.c           |   9 +-
 drivers/scsi/csiostor/csio_scsi.c            |  42 +--
 drivers/scsi/csiostor/csio_scsi.h            |   7 +-
 drivers/scsi/cxgbi/Makefile                  |   3 +
 drivers/scsi/cxgbi/libcxgbi.c                |  13 +-
 drivers/scsi/elx/Makefile                    |   1 +
 drivers/scsi/esas2r/Makefile                 |   3 +
 drivers/scsi/fcoe/Makefile                   |   3 +
 drivers/scsi/fcoe/fcoe_ctlr.c                |  50 +++-
 drivers/scsi/fnic/Makefile                   |   3 +
 drivers/scsi/fnic/fdls_disc.c                |  57 +++-
 drivers/scsi/fnic/fip.c                      |   2 +
 drivers/scsi/fnic/fnic_fcs.c                 |  21 +-
 drivers/scsi/fnic/fnic_fdls.h                |   7 +-
 drivers/scsi/fnic/fnic_scsi.c                |   4 +
 drivers/scsi/hisi_sas/Makefile               |   3 +
 drivers/scsi/hpsa.c                          |   2 +-
 drivers/scsi/ibmvscsi/Makefile               |   3 +
 drivers/scsi/ibmvscsi_tgt/Makefile           |   3 +
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c     |  34 ++-
 drivers/scsi/ipr.c                           |  46 ++--
 drivers/scsi/ips.c                           |   1 +
 drivers/scsi/isci/Makefile                   |   3 +
 drivers/scsi/libfc/Makefile                  |   2 +
 drivers/scsi/libfc/fc_disc.c                 |   7 +-
 drivers/scsi/libfc/fc_exch.c                 |   6 +
 drivers/scsi/libfc/fc_fcp.c                  |  17 +-
 drivers/scsi/libiscsi.c                      | 258 +++++++++++--------
 drivers/scsi/libiscsi_tcp.c                  |  17 +-
 drivers/scsi/libsas/Makefile                 |   2 +
 drivers/scsi/libsas/sas_ata.c                |   2 +-
 drivers/scsi/lpfc/lpfc_els.c                 |   2 +
 drivers/scsi/lpfc/lpfc_nportdisc.c           |   1 +
 drivers/scsi/lpfc/lpfc_scsi.c                |   1 +
 drivers/scsi/lpfc/lpfc_sli.c                 |   2 +
 drivers/scsi/mpt3sas/Makefile                |   3 +
 drivers/scsi/mvsas/Makefile                  |   2 +
 drivers/scsi/mvsas/mv_sas.c                  |   7 +
 drivers/scsi/pcmcia/Makefile                 |   2 +
 drivers/scsi/pm8001/Makefile                 |   1 +
 drivers/scsi/pm8001/pm80xx_hwi.c             |   2 +
 drivers/scsi/qedf/Makefile                   |   3 +
 drivers/scsi/qedi/Makefile                   |   3 +
 drivers/scsi/qedi/qedi_fw.c                  |  35 +--
 drivers/scsi/qla1280.c                       |  57 ++--
 drivers/scsi/qla2xxx/Makefile                |   3 +
 drivers/scsi/qla2xxx/qla_nx.c                |   2 +
 drivers/scsi/qla2xxx/qla_target.c            |  29 ++-
 drivers/scsi/qla2xxx/qla_tmpl.c              |   1 +
 drivers/scsi/qla4xxx/Makefile                |   3 +
 drivers/scsi/qla4xxx/ql4_isr.c               |   8 +-
 drivers/scsi/qla4xxx/ql4_nx.c                |   2 +
 drivers/scsi/scsi_transport_iscsi.c          |   1 +
 drivers/scsi/sg.c                            |   1 +
 drivers/scsi/smartpqi/Makefile               |   3 +
 drivers/scsi/smartpqi/smartpqi_init.c        |  67 ++++-
 drivers/scsi/snic/Makefile                   |   3 +
 drivers/scsi/st.c                            |   1 +
 drivers/scsi/sym53c8xx_2/Makefile            |   2 +
 include/linux/pci.h                          |   5 +-
 include/scsi/libiscsi.h                      |  23 +-
 92 files changed, 834 insertions(+), 405 deletions(-)