From: Daehyeon Ko <4ncienth@gmail.com>
To: David Ahern <dsahern@kernel.org>, Ido Schimmel <idosch@nvidia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Vladimir Vdovin <deliran@verdict.gg>,
Donald Hunter <donald.hunter@gmail.com>,
Amit Cohen <amcohen@nvidia.com>, Roopa Prabhu <roopa@nvidia.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Daehyeon Ko <4ncienth@gmail.com>
Subject: [PATCH net v2 0/3] ipv4: handle nexthop group shrink races
Date: Fri, 2 Oct 2026 13:50:57 +0900 [thread overview]
Message-ID: <cover.1790915964.git.4ncienth@gmail.com> (raw)
fib_info_num_path() and fib_info_nhc() can observe different RCU
generations of a replaceable nexthop group. An indexed consumer can
therefore accept an index from a larger group and receive NULL after a
concurrent shrink.
Patch 1 is unchanged from v1. Patch 2 addresses the analogous
fib_dump_info_fnhe() race Ido identified. Auditing the remaining
accessor pairs found the same issue in the RCU-only hardware-flag
notification path, fixed by patch 3. Separate patches retain the
correct Fixes tag for each concurrency boundary.
Thanks to Ido for the review and follow-up pointer.
---
v2:
- Carry Ido's Reviewed-by on unchanged patch 1.
- Add separate exception-dump and notification-sizing fixes.
v1: https://lore.kernel.org/netdev/20261001010550.2742297-1-4ncienth@gmail.com/
review: https://lore.kernel.org/netdev/20261001170513.GA1657889@shredder/
Validation:
- Patch 1 retains its deterministic vulnerable/fixed result.
- Patches 2 and 3 are source-audited only. No new allyesconfig or
allmodconfig W=1 build or runtime test was run.
Daehyeon Ko (3):
ipv4: stop PMTU walk when nexthop group shrinks
ipv4: stop exception dump when nexthop group shrinks
ipv4: stop route notification sizing when nexthop group shrinks
net/ipv4/fib_semantics.c | 3 +++
net/ipv4/route.c | 5 +++++
2 files changed, 8 insertions(+)
base-commit: 28bc1ef699610ee09ce3d46a00552f5a0a0144bd
--
2.55.0
next reply other threads:[~2026-10-02 4:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 4:50 Daehyeon Ko [this message]
2026-10-02 4:50 ` [PATCH net v2 1/3] ipv4: stop PMTU walk when nexthop group shrinks Daehyeon Ko
2026-10-02 4:50 ` [PATCH net v2 2/3] ipv4: stop exception dump " Daehyeon Ko
2026-10-04 8:02 ` Ido Schimmel
2026-10-02 4:51 ` [PATCH net v2 3/3] ipv4: stop route notification sizing " Daehyeon Ko
2026-10-04 8:20 ` Ido Schimmel
2026-10-06 23:30 ` [PATCH net v2 0/3] ipv4: handle nexthop group shrink races patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1790915964.git.4ncienth@gmail.com \
--to=4ncienth@gmail.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=deliran@verdict.gg \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.