All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nora Schiffer <nora.schiffer@ew.tq-group.com>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Isai Gaspar <isaiezequiel.gaspar@nxp.com>,
	Marek Vasut <marex@denx.de>,
	Pieterjan Camerlynck <pieterjanca@gmail.com>,
	Javier Carrasco <javier.carrasco.cruz@gmail.com>,
	linux@ew.tq-group.com, linux-leds@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nora Schiffer <nora.schiffer@ew.tq-group.com>
Subject: [PATCH v5 00/11] leds: pca995x: Minor fixes; reset, output-gain, error reporting and group brightness support
Date: Mon,  5 Oct 2026 15:53:24 +0200	[thread overview]
Message-ID: <cover.1791207391.git.nora.schiffer@ew.tq-group.com> (raw)

This series adds several new features to the PCA995x LED driver:

- Reset GPIO
- Output current configuration
- Error reporting via sysfs (short/open circuit)
- Group brightness control (modulating individual LED brightness with a
  second, chip-global PWM signal)

The series also includes a number of low-priority fixes:

- Prevent configuration of out-of-bounds LED indices on 16-channel variants
- Avoid fwnode leaks in error paths
- Finish initializing hardware before making LED devices visible to
  userspace

Changelog:

v5:
- Collect Reviewed-bys
- Limit fault detection to PCA9955B/PCA9956B. PCA9952/PCA9955 have a fault
  test feature that works differently and is not covered by this series.
- Correctly specify MODE2 reset defaults for all supported chips. The
  initialization of MODE2 is introduced in a separate patch now.

v4:
- Make code for output-gain range check and default value clearer
- Use dev_get_drvdata() instead of i2c_get_clientdata()
- Use devres for sysfs group

v3:
- Collect Reviewed-bys
- New patch: Fix fwnode handle leaks in error paths
- New patch: Write global registers before creating LED devices
- Add chip-global sysfs groups before creating LED devices

v2:
- Collect Reviewed-bys
- Use full hardware model names in commit descriptions
- Add nxp, to output-gain property
- Fix nxp,output-gain default in binding docs
- Describe rationale for using register value directly in commit message
- New patch: Fix maximum LED index for 16-channel variants
- Use correct #includes for GPIO consumer and delays
- Use udelay for small delay
- Use sysfs_streq() for has_errors write
- Explicitly initialize MODE2 register, clear reported errors on probe
- Set GRPPWM register on probe

Nora Schiffer (11):
  dt-bindings: leds: pca995x: Describe reset-gpios property
  dt-bindings: leds: pca995x: Describe nxp,output-gain property
  leds: pca995x: Fix maximum LED index for 16-channel variants
  leds: pca995x: Fix fwnode handle leaks in error paths
  leds: pca995x: Write global registers before creating LED devices
  leds: pca995x: Add support for reset GPIO
  leds: pca995x: Make output gain configurable
  leds: pca995x: Initialize MODE2 register on probe
  leds: pca995x: Add sysfs files for error reporting
  leds: pca995x: Do not use full on LED mode
  leds: pca995x: Add support for group brightness control

 .../devicetree/bindings/leds/nxp,pca995x.yaml |  13 +
 drivers/leds/leds-pca995x.c                   | 265 +++++++++++++++---
 2 files changed, 244 insertions(+), 34 deletions(-)

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/

             reply	other threads:[~2026-10-05 13:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 13:53 Nora Schiffer [this message]
2026-10-05 13:53 ` [PATCH v5 01/11] dt-bindings: leds: pca995x: Describe reset-gpios property Nora Schiffer
2026-10-05 14:21   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 02/11] dt-bindings: leds: pca995x: Describe nxp,output-gain property Nora Schiffer
2026-10-05 14:23   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 03/11] leds: pca995x: Fix maximum LED index for 16-channel variants Nora Schiffer
2026-10-05 14:27   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 04/11] leds: pca995x: Fix fwnode handle leaks in error paths Nora Schiffer
2026-10-05 14:28   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 05/11] leds: pca995x: Write global registers before creating LED devices Nora Schiffer
2026-10-05 14:24   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 06/11] leds: pca995x: Add support for reset GPIO Nora Schiffer
2026-10-05 14:25   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 07/11] leds: pca995x: Make output gain configurable Nora Schiffer
2026-10-05 14:25   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 08/11] leds: pca995x: Initialize MODE2 register on probe Nora Schiffer
2026-10-05 14:25   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 09/11] leds: pca995x: Add sysfs files for error reporting Nora Schiffer
2026-10-05 14:26   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 10/11] leds: pca995x: Do not use full on LED mode Nora Schiffer
2026-10-05 14:26   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 11/11] leds: pca995x: Add support for group brightness control Nora Schiffer
2026-10-05 14:27   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1791207391.git.nora.schiffer@ew.tq-group.com \
    --to=nora.schiffer@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=isaiezequiel.gaspar@nxp.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=marex@denx.de \
    --cc=pavel@kernel.org \
    --cc=pieterjanca@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.