From: Jonathan Santos <Jonathan.Santos@analog.com>
To: <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>
Cc: Jonathan Santos <Jonathan.Santos@analog.com>,
<dlechner@baylibre.com>, <broonie@kernel.org>,
<nuno.sa@analog.com>, <michael.hennerich@analog.com>,
<jonath4nns@gmail.com>, <andriy.shevchenko@intel.comls>
Subject: [PATCH v3 0/2] spi: axi-spi-engine: fix stale SYNC IRQ pending
Date: Wed, 7 Oct 2026 05:52:05 -0300 [thread overview]
Message-ID: <cover.1791361360.git.Jonathan.Santos@analog.com> (raw)
Both spi_engine_setup() and spi_engine_trigger_enable() send a SYNC(1)
command and poll SYNC_ID, but never clear INT_PENDING[SYNC] afterward.
This leaves a stale pending bit that fires spuriously when INT_SYNC is
enabled later by some driver, causing premature transfer completion at
low SPI clock frequencies (more likely). Fix both functions by clearing
the pending bit after polling.
v3 summary:
* Added a dummy read after the clear command to flush the posted writes
before dropping the lock.
* Link to v2: https://lore.kernel.org/linux-spi/cover.1790731588.git.Jonathan.Santos@analog.com/T/#t
v2 summary:
* Replaced "Link" tag for "Closes" tag.
* Included "Fixes" tag.
* Added new patch applying similar fix for the spi_engine_trigger_enable(),
as pointed out by David.
* While at it, replaced plain "1000" by "1 * USEC_PER_MSEC" for better
clarity.
* Link to v1: https://lore.kernel.org/linux-spi/04d51e99b8cddce51113db933d806e83848f04f5.1788313558.git.Jonathan.Santos@analog.com/T/#t
Jonathan Santos (2):
spi: axi-spi-engine: fix stale SYNC IRQ pending
spi: axi-spi-engine: fix stale SYNC IRQ pending in trigger_enable
drivers/spi/spi-axi-spi-engine.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
base-commit: 04434a1d0f311d76b1f15fa987918b471a0b8c6a
--
2.34.1
next reply other threads:[~2026-10-07 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 8:52 Jonathan Santos [this message]
2026-10-07 8:52 ` [PATCH v3 1/2] spi: axi-spi-engine: fix stale SYNC IRQ pending Jonathan Santos
2026-10-07 8:52 ` [PATCH v3 2/2] spi: axi-spi-engine: fix stale SYNC IRQ pending in trigger_enable Jonathan Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1791361360.git.Jonathan.Santos@analog.com \
--to=jonathan.santos@analog.com \
--cc=andriy.shevchenko@intel.comls \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jonath4nns@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.