From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs: further cleanup on fs_info->dirty_cowonly_roots
Date: Tue, 13 Oct 2026 09:28:46 +1030 [thread overview]
Message-ID: <cover.1791845501.git.wqu@suse.com> (raw)
Sashiko mentioned that dirty_cowonly_roots can still be non-empty if a
transaction aborts during commit_cowonly_roots().
However it should not cause any problem, as after a transaction is
aborted, no one will ever touch dirty_cowonly_roots.
So even if it has some dangling pointers, as long as no one is reading
it, it's completely fine.
Furthermore, dirty_cowonly_roots contains roots that are not subvolume
nor log trees, thus they should not have swapped qgroup blocks nor
dirty_log_pages. This means no memory leak from those two members
either.
But we're still depending on such quirky behavior, and it's only going
to cause more false alerts from various LLMs, e.g. Sashiko is already
reporting problems on this.
This series change the behavior to a dedicated cleanup, so that we no
longer relies on those hidden quirks.
Qu Wenruo (2):
btrfs: always remove quota_root from dirty_cowonly_roots
btrfs: cleanup dirty_cowonly_roots during btrfs_free_fs_roots()
fs/btrfs/disk-io.c | 14 ++++++++++++++
fs/btrfs/qgroup.c | 10 ++++++----
2 files changed, 20 insertions(+), 4 deletions(-)
--
2.56.0
next reply other threads:[~2026-10-12 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 22:58 Qu Wenruo [this message]
2026-10-12 22:58 ` [PATCH 1/2] btrfs: always remove quota_root from dirty_cowonly_roots Qu Wenruo
2026-10-12 22:58 ` [PATCH 2/2] btrfs: cleanup dirty_cowonly_roots during btrfs_free_fs_roots() Qu Wenruo
2026-10-13 5:41 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1791845501.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.