From: Anurag Mandal <anurag.mandal@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, anatoly.burakov@intel.com,
Anurag Mandal <anurag.mandal@intel.com>
Subject: [PATCH v2 0/7] net/ice: fix memory leaks
Date: Mon, 2 Nov 2026 08:10:30 +0000 [thread overview]
Message-ID: <cover.1793605751.git.anurag.mandal@intel.com> (raw)
In-Reply-To: <cover.1793097896.git.anurag.mandal@intel.com>
V2-changes:
- Addressed Bruce Richardson's review comments.
- Added "Cc: stable@dpdk.org" in all patches.
- Use ice_deinit_hw() on close instead of open-coding it,
which also returns the FD counter block to firmware
on Patch-2.
- Declare the devarg handler argument as char ** so the
filename it points to is char * and can be freed without
a cast on Patch-3.
- use RTE_CAST_PTR when freeing the filename in ice_dev_init()
on Patch-3.
- allocate the flow segment on the stack instead of
freeing it on Patch-7.
This series fixes memory leaks, and one double free, in the ice PMD.
a. The DDP package copy was freed twice when hardware table
initialization failed during probe.
b. The switch filter management structures, the DDP package copy and
any remaining VSI contexts were never freed on port close or
reset.
c. The DDP filename devarg string leaked on probe failure, and when
the devarg was given more than once.
d. The main VSI leaked when probe failed after PF setup.
e. MAC and VLAN filter entries could stay allocated when a VSI was
released.
f. A failed flow director setup leaked the FDIR VSI, hash table, hash
map and counter pools.
g. The flow segment used to create the ACL profiles leaked on every
ACL engine init.
Anurag Mandal (7):
net/ice: fix DDP package double free on init failure
net/ice: fix resource leaks on port close
net/ice: fix DDP filename leak
net/ice: fix main VSI leak on init failure
net/ice: fix MAC and VLAN filter leak on VSI release
net/ice: fix FDIR resource leak on setup failure
net/ice: fix ACL profile segment leak
drivers/net/intel/ice/ice_acl_filter.c | 46 +++++++++++--------------
drivers/net/intel/ice/ice_ethdev.c | 37 ++++++++++++++------
drivers/net/intel/ice/ice_fdir_filter.c | 10 ++++--
3 files changed, 54 insertions(+), 39 deletions(-)
--
2.25.1
next prev parent reply other threads:[~2026-11-02 8:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 10:51 [PATCH 0/7] net/ice: fix memory leaks Anurag Mandal
2026-10-27 10:51 ` [PATCH 1/7] net/ice: fix DDP package double free on init failure Anurag Mandal
2026-10-27 12:39 ` Bruce Richardson
2026-10-27 12:45 ` Bruce Richardson
2026-10-27 10:51 ` [PATCH 2/7] net/ice: fix memory leaks on port close Anurag Mandal
2026-10-27 13:17 ` Bruce Richardson
2026-10-27 10:51 ` [PATCH 3/7] net/ice: fix DDP filename leak Anurag Mandal
2026-10-27 13:52 ` Bruce Richardson
2026-10-27 10:51 ` [PATCH 4/7] net/ice: fix main VSI leak on init failure Anurag Mandal
2026-10-27 14:58 ` Bruce Richardson
2026-10-27 10:51 ` [PATCH 5/7] net/ice: fix MAC and VLAN filter leak on VSI release Anurag Mandal
2026-10-27 15:09 ` Bruce Richardson
2026-10-27 10:51 ` [PATCH 6/7] net/ice: fix FDIR resource leak on setup failure Anurag Mandal
2026-10-27 15:19 ` Bruce Richardson
2026-10-27 10:51 ` [PATCH 7/7] net/ice: fix ACL profile segment leak Anurag Mandal
2026-10-27 15:27 ` Bruce Richardson
2026-10-27 15:28 ` [PATCH 0/7] net/ice: fix memory leaks Bruce Richardson
2026-11-02 8:10 ` Anurag Mandal [this message]
2026-11-02 8:10 ` [PATCH v2 1/7] net/ice: fix DDP package double free on init failure Anurag Mandal
2026-11-02 8:10 ` [PATCH v2 2/7] net/ice: fix resource leaks on port close Anurag Mandal
2026-11-02 8:10 ` [PATCH v2 3/7] net/ice: fix DDP filename leak Anurag Mandal
2026-11-02 8:10 ` [PATCH v2 4/7] net/ice: fix main VSI leak on init failure Anurag Mandal
2026-11-02 8:10 ` [PATCH v2 5/7] net/ice: fix MAC and VLAN filter leak on VSI release Anurag Mandal
2026-11-02 8:10 ` [PATCH v2 6/7] net/ice: fix FDIR resource leak on setup failure Anurag Mandal
2026-11-02 8:10 ` [PATCH v2 7/7] net/ice: fix ACL profile segment leak Anurag Mandal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1793605751.git.anurag.mandal@intel.com \
--to=anurag.mandal@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.