All of lore.kernel.org
 help / color / mirror / Atom feed
From: hpa@zytor.com (H. Peter Anvin)
To: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] i386/power/cpu.c: remove three unused variables
Date: Tue, 18 Jan 2005 18:31:48 +0000 (UTC)	[thread overview]
Message-ID: <csjkmk$fu2$1@terminus.zytor.com> (raw)
In-Reply-To: 20050117152727.GB1379@elf.ucw.cz

Followup to:  <20050117152727.GB1379@elf.ucw.cz>
By author:    Pavel Machek <pavel@ucw.cz>
In newsgroup: linux.dev.kernel
>
> Hi!
> 
> > The patch below removes three unused variables.
> > 
> > Please check whether this patch is correct, or whether the variables 
> > should have been used.
> 
> The patch is probably correct (assuming %eax, %ecx and %edx are
> caller-saved on i386. [Honza, please confirm... I do not know i386
> calling convention by heart.]
> 							Pavel

%eax, %ecx, %edx, the FPU stack, the fsw, the XMM registers, and the
arithmetric flags are caller-saved.

I *think* eflags.df is also caller-saved.

	-hpa


  reply	other threads:[~2005-01-18 18:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-16  8:11 [2.6 patch] i386/power/cpu.c: remove three unused variables Adrian Bunk
2005-01-17 15:27 ` Pavel Machek
2005-01-18 18:31   ` H. Peter Anvin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-03-11 18:16 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='csjkmk$fu2$1@terminus.zytor.com' \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.