From: David Edmondson <david.edmondson@oracle.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [RFC 1/2] migration: Introduce ram_transferred_add()
Date: Mon, 20 Dec 2021 08:01:58 +0000 [thread overview]
Message-ID: <cuna6gvn1qh.fsf@oracle.com> (raw)
In-Reply-To: <1ecaa8aa-3b5c-ed91-3326-78376e4fe995@redhat.com> ("Philippe Mathieu-Daudé"'s message of "Fri, 17 Dec 2021 20:09:12 +0100")
On Friday, 2021-12-17 at 20:09:12 +01, Philippe Mathieu-Daudé wrote:
> On 12/16/21 13:34, David Edmondson wrote:
>> ...and use it.
>>
>> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
>> ---
>> migration/ram.c | 23 ++++++++++++++---------
>> migration/ram.h | 1 +
>> 2 files changed, 15 insertions(+), 9 deletions(-)
>
>> diff --git a/migration/ram.h b/migration/ram.h
>> index c515396a9a..a5b2ffdc18 100644
>> --- a/migration/ram.h
>> +++ b/migration/ram.h
>> @@ -51,6 +51,7 @@ int xbzrle_cache_resize(uint64_t new_size, Error **errp);
>> uint64_t ram_bytes_remaining(void);
>> uint64_t ram_bytes_total(void);
>> void mig_throttle_counter_reset(void);
>> +void ram_transferred_add(uint64_t bytes);
>
> Why make the method public? It seems an internal operation. Do you
> plan to use it elsewhere?
No such plan. Will fix in v2.
dme.
--
We wanna wait, but here we go again.
next prev parent reply other threads:[~2021-12-20 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 12:34 [RFC 0/2] migration: Tally pre-copy, downtime and post-copy bytes independently David Edmondson
2021-12-16 12:34 ` [RFC 1/2] migration: Introduce ram_transferred_add() David Edmondson
2021-12-17 19:09 ` Philippe Mathieu-Daudé
2021-12-20 8:01 ` David Edmondson [this message]
2021-12-16 12:34 ` [RFC 2/2] migration: Tally pre-copy, downtime and post-copy bytes independently David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cuna6gvn1qh.fsf@oracle.com \
--to=david.edmondson@oracle.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.