All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Coly Li <colyli@suse.de>, axboe@kernel.dk, linux-bcache@vger.kernel.org
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 2/5] bcache: Split out crc64 to library
Date: Tue, 22 May 2018 14:42:35 +0300	[thread overview]
Message-ID: <d00e1db87dec40dcc2a78f06a62e7df8fbfbdd51.camel@linux.intel.com> (raw)
In-Reply-To: <b7b0e4a9-10bf-dbff-f8ab-979345f3cd3b@suse.de>

On Tue, 2018-05-22 at 18:33 +0800, Coly Li wrote:
> On 2018/5/22 5:31 PM, Coly Li wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > For generic use split out crc64 code to a separate module
> > in the library folder.
> > 
> > No functional change intended.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Coly Li <colyli@suse.de>
> 
> Hi Jens and Andy,
> 
> After discussed on mailing list, I realize the original crc64 code was
> copied from postgreSQL with PostgreSQL license. So we are not able to
> move the code into lib/crc64 and grant GPL license to the symbols.

Indeed, I also didn't pay much attention to the exporting the symbols.
Another question if that code may be present in kernel in the first
place.

> I will ask lawyers about how to handle the license issue.
> For this moment I will hold this patch and not submit it to Linux
> v4.18.

You still can apply the rest of clean ups which do not touch this part.

> Sorry for the inconvenience.

I have to apologize as well for not being picky about licenses when was
cooking a patch.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2018-05-22 11:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22  9:31 [PATCH 0/5] bcache patches for 4.18 Coly Li
2018-05-22  9:31 ` [PATCH 1/5] bcache: stop bcache device when backing device is offline Coly Li
2018-05-22  9:31 ` [PATCH 2/5] bcache: Split out crc64 to library Coly Li
2018-05-22 10:33   ` Coly Li
2018-05-22 11:42     ` Andy Shevchenko [this message]
2018-05-22 13:03       ` Coly Li
2018-05-22  9:31 ` [PATCH 3/5] bcache: Move couple of string arrays to sysfs.c Coly Li
2018-05-22  9:31 ` [PATCH 4/5] bcache: Move couple of functions " Coly Li
2018-05-22  9:32 ` [PATCH 5/5] bcache: Replace bch_read_string_list() by __sysfs_match_string() Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d00e1db87dec40dcc2a78f06a62e7df8fbfbdd51.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.