All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Ted Vera <tedvera@gmail.com>, linux-sound@vger.kernel.org
Cc: regressions@lists.linux.dev, oder_chiou@realtek.com,
	lgirdwood@gmail.com, broonie@kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: ASoC: rt5677: Do not apply Yoga Book ACPI GPIO mappings to Samus
Date: Tue, 17 Nov 2026 09:11:13 +0100	[thread overview]
Message-ID: <d0219acc-0e2d-4bcd-b303-e7edaa236eec@linux.dev> (raw)
In-Reply-To: <CAFd_G9guhtVwE1aaFOXE3Ab43BAcwP3RBT=R_SdZ2KDfXB=LeQ@mail.gmail.com>

On 11/16/26 22:24, Ted Vera wrote:
> Summary:
> On a Google Pixel 2 LS Chromebook (Samus, EVT2) running Fedora 45
> kernel 7.3.3-300.fc45.x86_64, the RT5677 codec repeatedly fails probe
> with Failed to request POW_LDO2: -517 (-EPROBE_DEFER). The codec
> appears in devices_deferred, no RT5677 ALSA card is registered, and
> only HDMI audio is available.
> 
> The driver’s ACPI GPIO mapping added by commit 0cc00de3dd5b maps GPIO
> resource indexes 0 and 1 to reset and pow-ldo2 for every ACPI RT5677
> device. Samus’s DSDT uses those resources for codec GPIOs (jack detect
> and mic-present), not Yoga Book-style external reset and power GPIOs.
> The driver requests the mapped GPIOs before registering the codec’s
> GPIO chip, which appears to cause the deferred-probe loop.
> 
> Test and result:
> I built a temporary module against the matching Fedora kernel source
> that skips devm_acpi_dev_add_driver_gpios() on DMI board Samus. With
> that module, the RT5677 device bound successfully, the bdw-rt5677 ALSA
> card appeared, and laptop-speaker audio worked. Secure Boot remained
> enabled. This strongly supports the ACPI GPIO mapping as the cause.
> 
> Suggested fix: Restrict the mapping to devices whose ACPI GPIO
> resource layout matches the Yoga Book, rather than applying it to
> every RT5677 ACPI device.

Humm, it's a 2015 device that I used in the past without issues. It was
one of the early SOF devices... See commit bcb43fd.
Is this a commercial version or an early prototype? I don't recall what
EVT2 stands for in Chromebooks.
Also adding Andy in Cc:, he was the one who suggested the GPIO fixes.


  reply	other threads:[~2026-11-17  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 21:24 ASoC: rt5677: Do not apply Yoga Book ACPI GPIO mappings to Samus Ted Vera
2026-11-17  8:11 ` Pierre-Louis Bossart [this message]
2026-11-17 14:48   ` Ted Vera
2026-11-17 10:54 ` johannes.goede
2026-11-17 17:34   ` Pierre-Louis Bossart
2026-11-17 20:08     ` Yauhen Kharuzhy
2026-11-17 23:39     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0219acc-0e2d-4bcd-b303-e7edaa236eec@linux.dev \
    --to=pierre-louis.bossart@linux.dev \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=regressions@lists.linux.dev \
    --cc=tedvera@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.