Re: [PATCH v4] SDRAM Calibration Failed fix for GEN5 SoCFPGA

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Brian,

On 11/25/25 10:47 PM, Sune Brian wrote:
>> +       select CYCLIC
>> +       select SPL_CYCLIC
>>          select SPL_ALTERA_SDRAM
>>          imply FPGA_SOCFPGA
>>          imply SPL_SIZE_LIMIT_SUBTRACT_GD
> 
> Hi Quentin,
> 
> But interestingly do you tried any case that when defconfig
> had given
> CONFIG_CYCLIC=y
> CONFIG_SPL_CYCLIC=y
> but empty CMD_CYCLIC?
> 
> What my observation is that it is automatically turn on
> CMD_CYCLIC during .config recovery.
> 
> So I had no clue what you want on this correlated settings.

CMD_CYCLIC is enabled by default ("default y") if its dependencies are 
met (that is "CYCLIC" as specified by "depends on CYCLIC" in 
cmd/Kconfig). So when you enable CONFIG_CYCLIC via menuconfig, it 
enables (by default) CMD_CYCLIC as well. But you can disable it if you 
don't need it for example. If you add a "select OPTION" in an option in 
Kconfig, you cannot disable OPTION anymore.

CMD_CYCLIC is not required, so you shouldn't "depends on" or "select" it.

Cheers,
Quentin