From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD29AC6FA8F for ; Wed, 30 Aug 2023 08:47:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.592783.925612 (Exim 4.92) (envelope-from ) id 1qbGqx-00062W-5y; Wed, 30 Aug 2023 08:47:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 592783.925612; Wed, 30 Aug 2023 08:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qbGqx-00062P-34; Wed, 30 Aug 2023 08:47:07 +0000 Received: by outflank-mailman (input) for mailman id 592783; Wed, 30 Aug 2023 08:47:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qbGqv-0005Ww-V1 for xen-devel@lists.xenproject.org; Wed, 30 Aug 2023 08:47:05 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbb7fafe-4711-11ee-8783-cb3800f73035; Wed, 30 Aug 2023 10:47:05 +0200 (CEST) Received: from [192.168.8.109] (unknown [151.36.90.25]) by support.bugseng.com (Postfix) with ESMTPSA id 9135A4EE0738; Wed, 30 Aug 2023 10:47:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbb7fafe-4711-11ee-8783-cb3800f73035 Message-ID: Date: Wed, 30 Aug 2023 10:47:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 01/13] misra: add deviation for headers that explicitly avoid guards Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu References: <9b8165105c28f8e684844f56814726498e34c46e.1693228255.git.simone.ballarin@bugseng.com> From: Simone Ballarin Organization: BUGSENG In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/08/23 00:32, Stefano Stabellini wrote: > On Mon, 28 Aug 2023, Stefano Stabellini wrote: >> On Mon, 28 Aug 2023, Simone Ballarin wrote: >>> Some headers, under specific circumstances (documented in a comment at >>> the beginning of the file), explicitly avoid inclusion guards: the caller >>> is responsible for including them correctly. >>> >>> These files are not supposed to comply with Directive 4.10: >>> "Precautions shall be taken in order to prevent the contents of a header >>> file being included more than once" >>> >>> This patch adds a deviation for all headers that contain the following >>> in a comment text: >>> "In this case, no inclusion guards apply and the caller is responsible" >>> >>> Signed-off-by: Simone Ballarin >> >> Acked-by: Stefano Stabellini > > Actually one question > > >>> --- >>> automation/eclair_analysis/ECLAIR/deviations.ecl | 4 ++++ >>> docs/misra/rules.rst | 3 ++- >>> 2 files changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl >>> index d8170106b4..5f068377fa 100644 >>> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl >>> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl >>> @@ -91,6 +91,10 @@ conform to the directive." >>> -config=MC3R1.D4.10,reports+={safe, "first_area(text(^/\\* Generated file, do not edit! \\*/$, begin-3))"} >>> -doc_end >>> >>> +-doc_begin="Some headers, under specific circumstances, explicitly avoid inclusion guards." >>> +-config=MC3R1.D4.10,reports+={safe, "first_area(text(^ \\* In this case, no inclusion guards apply and the caller is responsible.*\\*/$, begin-1))"} >>> +-doc_end > > Is this supposed to match with any files starting with "In this case, > no inclusion..." ? > > We should use the format introduced by safe.json instead > I agree, I will do it in the next submission. -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com)