From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012014.outbound.protection.outlook.com [40.107.200.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1492935C1AE for ; Tue, 13 Jan 2026 19:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.14 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331421; cv=fail; b=CDGmDkSDtttBXwvOXWq/bVWsKhhUXaIYHNVCsFKIyZPoX7cowQw8/otVpFRD/wNAlyry1iOdDLIqV5THE3cr3BA36lSu2h5NLzZif8NN4oWMU6oOPblTwsTYFEafvBvDQa8ZiFkUFCANYZGXdzeadATWgou2wN2s7OOeIcQhex4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331421; c=relaxed/simple; bh=ek7XP+fhHKw8rAsOYkMBjD2iK81CPE/XjTc07Jyn+YQ=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=uqg01JyC8wTMyHDWGYCMg3rRhJJNCuH6y8HqPajkOpII+3iNK2LvGZdrfD1S1e3lAU6hTNJogYM49yLK/IzhH5NyE2tpwB28GGjNacwmBMEs3hf6HGd4NDP7FY5OOJ9I5FdSA1YuKe3EDFnSjGzYFI/s3diskY33aHPN6Kx4chU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NU9EFD0s; arc=fail smtp.client-ip=40.107.200.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NU9EFD0s" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eY7+DVXEZ8xHcACI6glw65BcC6P/2LxLChjr4GgGBRg0M0k0/YKhDTVdn4F/1duxVKJPnu4+TXBFBa7GD3i0/xOsMd76usnqduxWtI5lIEDGeVF7vMAxiWjmygutB1UjA1WiVXHAgwqtt+Nf7bEjX6EWKNiGkTKF0etX2qmlRrsogTnNimkNwOzkpebn311AcB0DG8kBVElpAPbswv5VEYiKFAeundL6UIPuKFeACDDewvt0AjrDyGcSiX5EtJbdIz/wweTL68cfIZldWbsp8s/mCQCYVfLbayIriH0+abxEA+mT6VWpRsozZDRoewNhcib+9iwO77/dXBOulBttlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xYiEov58cHX7WMOUnRfAX2XY8glxsFTMrQSRNyuRiXE=; b=XsWasvOZwFyTa/ONSJIYIM8a8uL8JT25Z0ZnlHW8HuEqyWEdpQgvD0X4m5/gcthbInHpXknlrkWTMjX4CUJZ0V6X5cqenaU8iDj4oF5gwsYEOPF1Q1DTOEMEFaNgx0tBCgZGsTteOEPmLK/4JqW2bituceKLjIU7+r0K1M5d01xjZjG/1UmSoeyfmg1hAtYgZXuw0ANo12ZB7PosQ2yGjxYd1Nxqy9sFphCqq5yQZ/8YDFMroVjPTwXdc5boqIslq7ExZsZ+H8yeaqc/Ju9BFefS6Aa0OAlEY8fOdDanAbOwed3kOyA2aTdyd4qViVLvlE5DbnwlpZk/0t/FKY2OMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYiEov58cHX7WMOUnRfAX2XY8glxsFTMrQSRNyuRiXE=; b=NU9EFD0svU7igZWFQ4S/ZMxeXfoAhIdllTUi5/niKW8fveVYZrfRfzEn23sUpZiaZE37Rd25Xcwpi6DTxiaw7CUm5d4q95EP2+QO/e7JKL1Nvdu9gu1qFsuqQrbsAA0SHKKFVc6aHFw5piNxw9EuNvZs4eranc5XKbZfASKwDCY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from IA0PPF9A76BB3A6.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bdc) by SA1PR12MB8699.namprd12.prod.outlook.com (2603:10b6:806:389::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Tue, 13 Jan 2026 19:10:15 +0000 Received: from IA0PPF9A76BB3A6.namprd12.prod.outlook.com ([fe80::8d61:56ca:a8ea:b2eb]) by IA0PPF9A76BB3A6.namprd12.prod.outlook.com ([fe80::8d61:56ca:a8ea:b2eb%8]) with mapi id 15.20.9478.004; Tue, 13 Jan 2026 19:10:15 +0000 Message-ID: Date: Tue, 13 Jan 2026 13:10:13 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] fs/resctrl: Add missing kconfig entry for CONFIG_RESCTRL_ASSIGN_FIXED To: Ben Horgan , linux-kernel@vger.kernel.org Cc: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, bp@alien8.de References: <20260113144952.47706-1-ben.horgan@arm.com> Content-Language: en-US From: Babu Moger In-Reply-To: <20260113144952.47706-1-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA9PR03CA0022.namprd03.prod.outlook.com (2603:10b6:806:20::27) To IA0PPF9A76BB3A6.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bdc) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PPF9A76BB3A6:EE_|SA1PR12MB8699:EE_ X-MS-Office365-Filtering-Correlation-Id: abd1444b-619a-4cc7-7c2a-08de52d7623f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZFhKS0RtR3dheDlDQXgvUVQrcStpZFRibGxIRS82OTVyWWxBSGdaYk5xM3Jp?= =?utf-8?B?WmRuRFF5UTlmTWl4Wk1NU1AwNW5KdlB4RkRTQ05STDl3dERkRFlPT0pvRUUy?= =?utf-8?B?bVB2NkNOSTM2VklWTlpTcmRid0JkclpUZXlWLzNkRGJ5aldtakE4UUc2N05M?= =?utf-8?B?N1Z0YmtoQ2JyTENVOGZHS1BlVm9HSGNaallEUFdGWldrMzVWNHdPbHdDR2NY?= =?utf-8?B?TEZJV1l2NjFBSmFjQ0VMOWMwNFBUaDRSbWE0MHVvbVhZYlVRdlZYcUszR2NF?= =?utf-8?B?dnJrNVhWQlZPMFlVaWJlRUlHV2NBNFNTQ04xOUdRZ3J0bTV5dGNraS9RZnhX?= =?utf-8?B?dEkwZk15ay9OWmljK2NEWXNIZlNRSnNsTlplZktXdHh3aW9lMGhNYm5mRWo3?= =?utf-8?B?SlVwTSsrZjA1dTlEQ29WOU1yajRFYUR2aW5iU1k1VmpibndrTXpsZW16R1Zl?= =?utf-8?B?YU8vM2dHRnVybUFhODBOc3NwaXRnQXZBQVN6c3FyNTRvazd2QW12T3IwTzJD?= =?utf-8?B?ay9zREd2bVFWaUdhL2lnejFHT01OZ2lBV3p4SFZoblBGNFg2dXBZNk5ZMk1P?= =?utf-8?B?dmhRbHRIbXhPWTNtQXdKSWRmOG5FemcxOXloQnJWVUcxYVRnQUJwMDNxY1NO?= =?utf-8?B?clB4SGJsR3o1V2hRVlB0UWVXcnJyZEVMMUdiZ1cxWEVoeFRrckpJaGVsbnVH?= =?utf-8?B?VHBRb1FJSEFFdXVMV1d5TW5ZV3RIaEZWaStIUnNlcDhWYTBBRi9MVlhJQjlr?= =?utf-8?B?dkdEVStNTFBQYVNpbWp6WjdlSXd0aHJVb2FPYXBlWjI3SmhTcHkwTmQ2QkNo?= =?utf-8?B?UlhSWjVZZnhiVnJOTXovM3lBNG5Fb0dxckpvRVBXRVBaOEJwekVRNkJUd3J0?= =?utf-8?B?Mm5FRkNscytEMEVZL1ZKZWRONXFmZUJFMldJR1BaZ1FKSlpOLzhmNXBDdTFI?= =?utf-8?B?NG8rYnE3S1VEN0wrSFhIaW8vN25WOWlKckVMWURhZjZqSEpYS01DYWJRZE5V?= =?utf-8?B?ajBRR0lZcDJXUGVXSlRXRU1yZCt1YllZQUxVeGFEd0NZeXFwNGVrVHp5STYw?= =?utf-8?B?Y1FXMXhOTUc2dytBN09oZUZJdTFYejJXeWxkSGw3Mkt2SUxBeWt2OFV1RWRU?= =?utf-8?B?Y2hHSUtRQktRdDhoUlVTVjdid29LbTlCU3FCcDVBSkE2OXV6aUNUaWkwbkQw?= =?utf-8?B?cjRhRUxWRXZhT3FFcXJjS1RqOXdnbkc5WGMrYUQ0dmNjbXVlUnM3cWVNbUZI?= =?utf-8?B?bzFjMFZ2czNNTW1LNmZuN0Vta2xVb2cwL2hpYmtGSjk0anpjT0dSUis0Z1RK?= =?utf-8?B?dHZGZ0wwVnJWU0N0eGtnWCtsSGFHOEU4elNZRFZFdGcxRmJCekw1dHFUSkNC?= =?utf-8?B?UVcvNDNWdVNJMys5bGh3Q2xJWmNIZVNaS1pPb1lBT1lST3NTWVhINHl0dGVN?= =?utf-8?B?eEswdis5K01ZVFlOM014bnFsMmt3MTlWbE1mamE0bDJTODlNeVJ5QzJ4YnVN?= =?utf-8?B?VTQrSnhNVmk2YUdoVUJINDluOFQ3anBQQmpDUnEwSG1keXVIUmZQL3dWeEx4?= =?utf-8?B?TWw4MWNzVHVKdW02SUhKaUxpRnhIbklSejJrcncxQWxRT2szNkJCb1F2NmxO?= =?utf-8?B?YzdFM29PaEdyWGt5aUdOWm1ncXpYdElDU29CUytQUmlaNGV1ZGJkY3lrSG5V?= =?utf-8?B?WjZDVHluVTJBZTNncHBnR0dSbXNZWjN2dmQ0Sjl0bUJoY045N3QxRU5YQnY1?= =?utf-8?B?QWltMVhHQVAvWHhxSUtGYnlKMmxDKy80czRSTzBBQnRXY2taeFZESmxEVnZE?= =?utf-8?B?dXpXOXVnTDBDaVFQZ0h1YkszdWd3dktabXlhUkFDRTdrWFVXWkJZbVBwMHBu?= =?utf-8?B?cVR4d0VwNU56RHdoR05pa0dueEptend6akMwWVRGZmZmcmNBc3AvZ3Vyb2Fq?= =?utf-8?Q?1e+/FOi9H29MdsbFnWIW0aWgoUwtfr8C?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PPF9A76BB3A6.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Lys2ZEEvaThLMUNHT2g5ZmZ5WGVCbklLVVE4QXdaMTNvaTJnRU11MHlscURr?= =?utf-8?B?bVl6Y09wbjFhanJoRGdwNTdoQ2hRMDBtSHZ6MEFyalBtZng1YnB4TUo2NVdB?= =?utf-8?B?T2RkRWhibFJaRmswU096NmxkcE1TMFNxK3FPTlJZSzhEcG04Zzk4cldLalE0?= =?utf-8?B?ck9YV3hwZEN2SEpFZnBDeU8vL2JoS0tmN29YUXBGOG5EbHp4aGxVQ3Z6WVdY?= =?utf-8?B?L2xuV2xOaFY4QTc2dkx4TlB4L3BKY2V3SHlTY2tvT3NUZEZrUEtIMmYya0lM?= =?utf-8?B?dEdGd01KRHFKUFFYZlg1czZMWmJkOGREbExvaXFxWTZEQ0lrUDBhQ3k2N0Q3?= =?utf-8?B?R3prNExBbjBFZ1hIN3BWdE95UWh3TWhEaDltQmVMRjYycStjM1g3aUlpZVhM?= =?utf-8?B?TUNVVDNxK1p1WEsyZk5zeU5SaTd1MkZUUXJDSERMeW1xejJrMXhrL25ia2hs?= =?utf-8?B?bmJIRUJPZ1RNby9HZGVSQlhYNUo0Zy8rdHZKSGZpU1o1L2FxYUtEd21BRE1m?= =?utf-8?B?Slc1YXcrbXBwQWptekMwSThyMjh6WXFOeTZSWEN1amRTcWZCdFE5M1d2YjB5?= =?utf-8?B?cVlzZEJnSXBWdjR2TDBEUGJpRy9Ta3BGTXZZU3lPRzkwd1NVeUpHait2azFT?= =?utf-8?B?ZnVVeWx4Ymx0b0FGWDBIRnB4aElpQi9yb0pqR0ttYVhoNlozMFlYOHVGUWNP?= =?utf-8?B?aDkwYWZZelpERTFrYmt2TkV3a0FvV1FiMFV0UGFEZFVQRUlPVkFJK0VPRnBI?= =?utf-8?B?UllkYjJPeVBFb0dFNUtqY2k5b053by9qVFNuaDh3ajF6Zm1DSXBaaUVISGhw?= =?utf-8?B?dmpHYTRsRFMrdkJOSnZzMk1TUHpWRUtCa0lYRWUzWVZZSHZjRlJiQ21Mc2VY?= =?utf-8?B?OEJzSU82bHNtak84SkNXWiszMHN5OXNGeFFPZjNDc2tid1hZUFNoakNML1k5?= =?utf-8?B?K2lJNk5VbGhJQ08weFR4ZkVyaGkzWHoyS1dBY0dxNjJVT3lxZk16NEdsdHZX?= =?utf-8?B?Y0lsOGQ5TkFyem9Sd2lNdVhLMWYrODh6S2tWRnljUnprc2pSdWZ2TEl3Wm5a?= =?utf-8?B?WXA4V3FzeVFqcDJSbTFsOTdGZjRoZHpCYVF0S2QyVlhqVTRtMm5wcm11dkhw?= =?utf-8?B?L3huMnNadnlnUk9OS3h1dllLSGdYQ3lOUDdIdXdYdUJrYTg3MlkrYlhwT25I?= =?utf-8?B?UWZSWUEwNlZpb1MvQitvbTFNQi92a0RtVW1QL2dPTklvZEdCZE5uNlRodDJ6?= =?utf-8?B?RHptYTJoZDc1ZW9vS0IwSmQ3ekN2eDJoUGdpQTBLY2NVb1VGZmxQTUZ5eHRj?= =?utf-8?B?NE1aaWhsMCsyNFNpLzFuTW13ZkNtK1U3Q2IyRFA3VitJaUtrM3pRdG42UGlF?= =?utf-8?B?Y1JzbFpxWVdhSlM5TC9DUDh3WUlNM3A0VCtwTzBMbzlXOFRWUUpPd3VwZjYv?= =?utf-8?B?Nm1rdXNha0FzbC9TL1ZCajc2bCtadWUzMGRXRmxXRXByaXBWbmJaQ3VYblZR?= =?utf-8?B?Q1FZMVN6ME00TXlDaUdmU1ZMV1B3a2FuZnp3RWFUV1VrT1l6NTltNUd6dGpH?= =?utf-8?B?ZnFKeFBjNm01a2t5dTNGdWl1c0NZekR6QWpXaTIxZmRMVmh3ODQyd2ZaWVJD?= =?utf-8?B?ZHovaG4vSXZXY2U0dHJka09kNno3RWltbjlldXp1eUNQdVlUOHlZVTdTY01D?= =?utf-8?B?Z1JzcDYrZ0trOXg4NDVlekVjQ3BSanZnYUJkOVJ1K0NKOVFodzAzbzdiUDFS?= =?utf-8?B?anBzMTV3bHhXMll2WjQvRnIvZ2VKL3FRWlV6Y0FzcGVlaUw0L3ozTU8yUU5I?= =?utf-8?B?M2tIYjBLYy9rWkQxWWllSVhQblVOSU9LdmE2NkpEVFI3Q0w0aC9tNlVUUGhK?= =?utf-8?B?a1o4LzRlT21PTGptQ00vVTRna0FCTG9BeVNFMmNYZS95QjQ3QUY2cXg4NUM3?= =?utf-8?B?UFBjOGJxMEtxVjVHZnYvWWRvQjNwckdqTTh3SnhQcW83alNXcVFxM1ZINFZp?= =?utf-8?B?ZTFkQUY2YkgvZ0h3SkhjZTZrM0NwV2VvK20rLzhxK1BOaVBWUTVQa2lrVUJC?= =?utf-8?B?ZllCL1l3Ym9sWEtMMXprNWxoMTRWZHNDRHQrRzVjOUNCUGV2L0ltYkF0eGN3?= =?utf-8?B?bUJmSm9WRW5PMkcxZEJTMWxCNXF6bXRmYUZJSDV5NFRCeGdsZzcrcjlTVGRL?= =?utf-8?B?YVRlbVh2bU5TNllTVThidU1hcmlPOFp2aDlCQTRFdzdGdnlyWWNNbEtzRndQ?= =?utf-8?B?YkMwNEdoOE9QL1hDMlE4b0NLbVluR0o5WFFsZmlrdEJQb3hPYjE4bGxrQTNw?= =?utf-8?Q?4mJdSZwGWUC1NqP86o?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: abd1444b-619a-4cc7-7c2a-08de52d7623f X-MS-Exchange-CrossTenant-AuthSource: IA0PPF9A76BB3A6.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2026 19:10:15.5492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X9fFolUaYPOJPbBNKJBmE1MVuxQFDFJpEYVoZA0T07QKWcj9OghlFDtLgfcsyO0b X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8699 Hi Ben, On 1/13/26 08:49, Ben Horgan wrote: > The commit 3b497c3f4f04 ("fs/resctrl: Introduce the interface to display > monitoring modes") introduced CONFIG_RESCTRL_ASSIGN_FIXED but did not add > the kconfig entry. Add this. Add this -> Add the missing configuration option  or Add the missing Kconfig option. ? > > Also, take the opportunity ensure that any user attempt to change the > assign mode fails from the resctrl code rather than delegating to the arch assign mode -> counter assignment mode > specific code and let the user know by adding a message in last_cmd_status. > > Fixes: 3b497c3f4f04 ("fs/resctrl: Introduce the interface to display monitoring modes") > Signed-off-by: Ben Horgan > --- > fs/resctrl/Kconfig | 8 ++++++++ > fs/resctrl/monitor.c | 6 ++++++ > 2 files changed, 14 insertions(+) > > diff --git a/fs/resctrl/Kconfig b/fs/resctrl/Kconfig > index 21671301bd8a..bdf9e11502fa 100644 > --- a/fs/resctrl/Kconfig > +++ b/fs/resctrl/Kconfig > @@ -37,3 +37,11 @@ config RESCTRL_RMID_DEPENDS_ON_CLOSID > Enabled by the architecture when the RMID values depend on the CLOSID. > This causes the CLOSID allocator to search for CLOSID with clean > RMID. > + > +config RESCTRL_ASSIGN_FIXED > + bool > + depends on RESCTRL_FS > + help > + Enabled by the architecture when the counter assignment mode is not > + configurable. This ensures that counter assignment is not advertised as > + configurable and configuration attempts fail. > diff --git a/fs/resctrl/monitor.c b/fs/resctrl/monitor.c > index 572a9925bd6c..888e303c18a2 100644 > --- a/fs/resctrl/monitor.c > +++ b/fs/resctrl/monitor.c > @@ -1434,6 +1434,12 @@ ssize_t resctrl_mbm_assign_mode_write(struct kernfs_open_file *of, char *buf, > > rdt_last_cmd_clear(); > > + if (IS_ENABLED(CONFIG_RESCTRL_ASSIGN_FIXED)) { > + ret = -EINVAL; > + rdt_last_cmd_puts("assign mode is not configurable\n"); assign mode -> counter assignment mode > + goto out_unlock; > + } > + > if (!strcmp(buf, "default")) { > enable = 0; > } else if (!strcmp(buf, "mbm_event")) {