From: Krzysztof Kozlowski <krzk@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH v3] media: platform: exynos4-is: Use of_get_available_child_by_name()
Date: Mon, 7 Apr 2025 15:30:24 +0200 [thread overview]
Message-ID: <d07e4e1a-2b83-461a-b259-91c7e80e0ed8@kernel.org> (raw)
In-Reply-To: <20250407110516.41124-1-biju.das.jz@bp.renesas.com>
On 07/04/2025 13:05, Biju Das wrote:
> Simplify fimc_md_is_isp_available() by using
> of_get_available_child_by_name().
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v2->v3:
> * Fixed CHECK: Comparison to NULL could be written "child" reoported by
> [1] https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/74116132/artifacts/report.htm
> * Dropped Rb tag from Krzysztof.
And what is the reason? Minor tweak for checkpatch? Really?
Please follow closely submitting patches about review tags.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-07 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 11:05 [PATCH v3] media: platform: exynos4-is: Use of_get_available_child_by_name() Biju Das
2025-04-07 13:30 ` Krzysztof Kozlowski [this message]
2025-04-07 13:36 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d07e4e1a-2b83-461a-b259-91c7e80e0ed8@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.