From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2 1/2] nvme: introduce nvme_start_request
Date: Tue, 29 Nov 2022 07:32:26 -0700 [thread overview]
Message-ID: <d07eee61-eb3f-de75-4cc2-d9c554640a2b@kernel.dk> (raw)
In-Reply-To: <Y4YXDAZDZQbnLIbF@kbusch-mbp.dhcp.thefacebook.com>
On 11/29/22 7:28 AM, Keith Busch wrote:
> On Mon, Oct 03, 2022 at 12:43:43PM +0300, Sagi Grimberg wrote:
>>
>> +void nvme_start_request(struct request *rq)
>> +{
>> + blk_mq_start_request(rq);
>> +}
>> +EXPORT_SYMBOL_GPL(nvme_start_request);
>
> Looks good, other than I feel this should be a static inline function in
> nvme.h instead.
Hah, mid-air collision. But at least we agree :-)
--
Jens Axboe
next prev parent reply other threads:[~2022-11-29 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 9:43 [PATCH v2 0/2] nvme-mpath: Add IO stats support Sagi Grimberg
2022-10-03 9:43 ` [PATCH v2 1/2] nvme: introduce nvme_start_request Sagi Grimberg
2022-10-04 6:09 ` Hannes Reinecke
2022-11-29 14:28 ` Keith Busch
2022-11-29 14:32 ` Jens Axboe [this message]
2022-11-29 14:31 ` Jens Axboe
2022-10-03 9:43 ` [PATCH v2 2/2] nvme: support io stats on the mpath device Sagi Grimberg
2022-10-04 6:11 ` Hannes Reinecke
2022-10-04 8:19 ` Sagi Grimberg
2022-11-29 14:33 ` Jens Axboe
2022-11-29 14:33 ` Jens Axboe
2022-11-29 14:42 ` Keith Busch
2022-11-29 14:45 ` [PATCH v2 0/2] nvme-mpath: Add IO stats support Christoph Hellwig
2022-11-29 16:43 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d07eee61-eb3f-de75-4cc2-d9c554640a2b@kernel.dk \
--to=axboe@kernel.dk \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.