From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A30257A for ; Fri, 10 Jun 2022 19:51:19 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id me5so47440ejb.2 for ; Fri, 10 Jun 2022 12:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=bNY4bb5ZsDGbijlscX/zWHp76bvVhoKTJQjCK2gLBow=; b=DTARzN9ZKxLbpM5DnF604iI8/F/84/wIKw08CbQfw05YnVX88YGW6HVfBxQNHvMu4T MLrV3I1t6KM5Qc6HlnyeXHSTGoq8+8DaWtqoRUwsLbX6Mzc8EpX122ha3qRBRoFfEqzN Jk0f/3X9FLtgjhjaqJKanWVijWyNNRgDw6pmj5+2xfApIvc2SRAwOjLitceTonJ4eGE1 a1A9wbvVgJFRqD/0S50YXqjQh+yziCS7x5lzFW9SKapPD3uUc9it44OjhImJd8j2+oZt Butz14g0HcCbwqNDkTuGrH/EVS+NkDJB41ZnGmOfym00EegEpO7qNAqhl52gA+RezkJc GTxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bNY4bb5ZsDGbijlscX/zWHp76bvVhoKTJQjCK2gLBow=; b=nyCepq+g62kUq6rk9K0FfTzB9R/iNS1+V7fYzUV6o+G57j56LAqbMkoDicrD0ZwYfF m01eGRRM1rs0qvC6P/Te/9DTRAu4JWp8G6diY6VlxzKBDPopdwpN1FhmHeF+QGW58VBD QMp8fsB/K4MdE/cnZqsvhh1sb0WgzUYbUs3iRNZp/E1zMr36NFcQpNbP6Y+s+PVFILZ1 EU7FlkEaMvd7NaFSTDDIxrTrwtFKZIqFJ+jQngVa3DtbaUUORwhuwFhddBTIWFWiORB5 MDpDPC71lDl7vbxaGlFLAL3S0DD40Cltp1uYGQxk4hMPSR0T/+EABB/3QxVkN7DnQ60Y gsiw== X-Gm-Message-State: AOAM5318BFiBPpN5nB6IKyHei4qriypmaZz/q2zvmd5cQSoFWNPn+t9M oZOiGQFKiDAHAj+4J9TenGg= X-Google-Smtp-Source: ABdhPJxHRykgXinV3uoaEPm9Ud4a9M4gnh2v3qf5U98udrI7NhTVLe93fDw1Gnx05NF5PsnFjGIIwQ== X-Received: by 2002:a17:906:51d6:b0:712:c9:8a1b with SMTP id v22-20020a17090651d600b0071200c98a1bmr10665567ejk.656.1654890677793; Fri, 10 Jun 2022 12:51:17 -0700 (PDT) Received: from ?IPv6:2001:a61:136e:3c01:8bd4:cf6f:76f1:a861? ([2001:a61:136e:3c01:8bd4:cf6f:76f1:a861]) by smtp.gmail.com with ESMTPSA id ck16-20020a170906c45000b006feb20b5235sm12715703ejb.84.2022.06.10.12.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 12:51:17 -0700 (PDT) Message-ID: Subject: Re: [PATCH 34/34] iio: inkern: fix coding style warnings From: Nuno =?ISO-8859-1?Q?S=E1?= To: Joe Simmons-Talbott , Nuno =?ISO-8859-1?Q?S=E1?= Cc: linux-imx@nxp.com, linux-renesas-soc@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, Lad Prabhakar , linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, openbmc@lists.ozlabs.org, Cai Huoqing , Benjamin Fair , Jishnu Prakash , Linus Walleij , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , Alexandre Belloni , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , Gwendal Grignou , Saravanan Sekar , Tali Perry , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , Lorenzo Bianconi , Claudiu Beznea , Pengutronix Kernel Team , Andy Shevchenko , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , Nicolas Ferre , Jonathan Cameron , Zhang Rui , Shawn Guo , Guenter Roeck , Fabio Estevam , Olivier Moysan , Eugen Hristev , Miquel Raynal Date: Fri, 10 Jun 2022 21:51:15 +0200 In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-35-nuno.sa@analog.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 2022-06-10 at 11:53 -0400, Joe Simmons-Talbott wrote: > On Fri, Jun 10, 2022 at 10:45:45AM +0200, Nuno Sá wrote: > > Just cosmetics. No functional change intended... > > > > Signed-off-by: Nuno Sá > > --- > >  drivers/iio/inkern.c | 64 ++++++++++++++++++++++------------------ > > ---- > >  1 file changed, 32 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c > > index 7eb536560ded..526519cefcb9 100644 > > --- a/drivers/iio/inkern.c > > +++ b/drivers/iio/inkern.c > > @@ -45,13 +45,13 @@ int iio_map_array_register(struct iio_dev > > *indio_dev, struct iio_map *maps) > >         int i = 0, ret = 0; > >         struct iio_map_internal *mapi; > >   > > -       if (maps == NULL) > > +       if (!maps) > >                 return 0; > >   > >         mutex_lock(&iio_map_list_lock); > > -       while (maps[i].consumer_dev_name != NULL) { > > +       while (!maps[i].consumer_dev_name) { > > Shouldn't this be?: > while (maps[i].consumer_dev_name) { > Ups... Nice catch! I was probably in bot mode already. - Nuno Sá From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 328A0C433EF for ; Fri, 10 Jun 2022 19:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n7f2ex6TZXgQc5F4j7Iik4jDwTzCMvKQiZFexS5O8/4=; b=CbFFaYyvCEUJsU lI1agXm0Zi6pNl919HlV5S1HNtmEYg6CnyNKtOkIH4we7ekumLA0VAK13agfg7sMRXYsXpObZG4IG smsrSqlGzMM/6b1HqgGDF7ViZUaJR+YGJVkTRC0a5jobb9VoJyM3ekEIh8Mu33ezwdw0iCilgGIz5 LaBqLBgxfdyqUitX1X21rsmkIgzrGe3hCxrvv2YKlkC864IrfpawdvldkOCFw4rkuf3EbXbpn1710 Tk1A2sovoKJUxXdrMFTeyQuOPheX2t6YfXC3JZAhB6ITCOD0/wm9ykeiZxULGogr1oUZaX867hpPI WOjS+YmSc+CT5n2zAtOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzkfC-009ajD-S2; Fri, 10 Jun 2022 19:51:22 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzkf9-009ahp-W3; Fri, 10 Jun 2022 19:51:21 +0000 Received: by mail-ej1-x633.google.com with SMTP id g25so8875921ejh.9; Fri, 10 Jun 2022 12:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=bNY4bb5ZsDGbijlscX/zWHp76bvVhoKTJQjCK2gLBow=; b=DTARzN9ZKxLbpM5DnF604iI8/F/84/wIKw08CbQfw05YnVX88YGW6HVfBxQNHvMu4T MLrV3I1t6KM5Qc6HlnyeXHSTGoq8+8DaWtqoRUwsLbX6Mzc8EpX122ha3qRBRoFfEqzN Jk0f/3X9FLtgjhjaqJKanWVijWyNNRgDw6pmj5+2xfApIvc2SRAwOjLitceTonJ4eGE1 a1A9wbvVgJFRqD/0S50YXqjQh+yziCS7x5lzFW9SKapPD3uUc9it44OjhImJd8j2+oZt Butz14g0HcCbwqNDkTuGrH/EVS+NkDJB41ZnGmOfym00EegEpO7qNAqhl52gA+RezkJc GTxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bNY4bb5ZsDGbijlscX/zWHp76bvVhoKTJQjCK2gLBow=; b=sddw+N8cPlMMXpnwlhbCRyNaLgYU1lIomCz9oNQWZA53hfxnmP9CacgfPrmAikLM1h qC5SRnzWfy+TniXdLV436IivI5do2ax1P91kATovL0Hz8ICOMt64znHicVThRblfOOe4 bivxuV7JJd2mSvb7LpSF8QXxVw94SuYzq2IITaL9aZvTE/ZGEeTVzNprGG0O86XDKIes AtgYR2ggfkghOSsI3HnaI4NKgoDsJJHo5+0SMJ3dwGD2HoaM2Voic/1NboOCbDEhCBm/ D2KcLCK4vzHc76ThQgapAAjkLQwwQ3qHpybb8y2HZhrlSbAGFUla36nR7AjLhQQH4Jui 1qRQ== X-Gm-Message-State: AOAM533TQbiWp1bMvRI7JYiMnYOYZHn5XnOeo7vyFTuvXqTr+wFEyJ9Z 3lfj/orCYgcUc8aNZ6ZawT0= X-Google-Smtp-Source: ABdhPJxHRykgXinV3uoaEPm9Ud4a9M4gnh2v3qf5U98udrI7NhTVLe93fDw1Gnx05NF5PsnFjGIIwQ== X-Received: by 2002:a17:906:51d6:b0:712:c9:8a1b with SMTP id v22-20020a17090651d600b0071200c98a1bmr10665567ejk.656.1654890677793; Fri, 10 Jun 2022 12:51:17 -0700 (PDT) Received: from ?IPv6:2001:a61:136e:3c01:8bd4:cf6f:76f1:a861? ([2001:a61:136e:3c01:8bd4:cf6f:76f1:a861]) by smtp.gmail.com with ESMTPSA id ck16-20020a170906c45000b006feb20b5235sm12715703ejb.84.2022.06.10.12.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 12:51:17 -0700 (PDT) Message-ID: Subject: Re: [PATCH 34/34] iio: inkern: fix coding style warnings From: Nuno =?ISO-8859-1?Q?S=E1?= To: Joe Simmons-Talbott , Nuno =?ISO-8859-1?Q?S=E1?= Cc: linux-imx@nxp.com, linux-renesas-soc@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, Lad Prabhakar , linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, openbmc@lists.ozlabs.org, Cai Huoqing , Benjamin Fair , Jishnu Prakash , Linus Walleij , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , Alexandre Belloni , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , Gwendal Grignou , Saravanan Sekar , Tali Perry , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , Lorenzo Bianconi , Claudiu Beznea , Pengutronix Kernel Team , Andy Shevchenko , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , Nicolas Ferre , Jonathan Cameron , Zhang Rui , Shawn Guo , Guenter Roeck , Fabio Estevam , Olivier Moysan , Eugen Hristev , Miquel Raynal Date: Fri, 10 Jun 2022 21:51:15 +0200 In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-35-nuno.sa@analog.com> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_125120_074584_3A4CB4A9 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMDIyLTA2LTEwIGF0IDExOjUzIC0wNDAwLCBKb2UgU2ltbW9ucy1UYWxib3R0IHdy b3RlOgo+IE9uIEZyaSwgSnVuIDEwLCAyMDIyIGF0IDEwOjQ1OjQ1QU0gKzAyMDAsIE51bm8gU8Oh IHdyb3RlOgo+ID4gSnVzdCBjb3NtZXRpY3MuIE5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVk Li4uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE51bm8gU8OhIDxudW5vLnNhQGFuYWxvZy5jb20+ Cj4gPiAtLS0KPiA+IMKgZHJpdmVycy9paW8vaW5rZXJuLmMgfCA2NCArKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAtLS0tCj4gPiDCoDEgZmlsZSBjaGFuZ2VkLCAz MiBpbnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaWlvL2lua2Vybi5jIGIvZHJpdmVycy9paW8vaW5rZXJuLmMKPiA+IGluZGV4IDdlYjUz NjU2MGRlZC4uNTI2NTE5Y2VmY2I5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9paW8vaW5rZXJu LmMKPiA+ICsrKyBiL2RyaXZlcnMvaWlvL2lua2Vybi5jCj4gPiBAQCAtNDUsMTMgKzQ1LDEzIEBA IGludCBpaW9fbWFwX2FycmF5X3JlZ2lzdGVyKHN0cnVjdCBpaW9fZGV2Cj4gPiAqaW5kaW9fZGV2 LCBzdHJ1Y3QgaWlvX21hcCAqbWFwcykKPiA+IMKgwqDCoMKgwqDCoMKgwqBpbnQgaSA9IDAsIHJl dCA9IDA7Cj4gPiDCoMKgwqDCoMKgwqDCoMKgc3RydWN0IGlpb19tYXBfaW50ZXJuYWwgKm1hcGk7 Cj4gPiDCoAo+ID4gLcKgwqDCoMKgwqDCoMKgaWYgKG1hcHMgPT0gTlVMTCkKPiA+ICvCoMKgwqDC oMKgwqDCoGlmICghbWFwcykKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0 dXJuIDA7Cj4gPiDCoAo+ID4gwqDCoMKgwqDCoMKgwqDCoG11dGV4X2xvY2soJmlpb19tYXBfbGlz dF9sb2NrKTsKPiA+IC3CoMKgwqDCoMKgwqDCoHdoaWxlIChtYXBzW2ldLmNvbnN1bWVyX2Rldl9u YW1lICE9IE5VTEwpIHsKPiA+ICvCoMKgwqDCoMKgwqDCoHdoaWxlICghbWFwc1tpXS5jb25zdW1l cl9kZXZfbmFtZSkgewo+IAo+IFNob3VsZG4ndCB0aGlzIGJlPzoKPiB3aGlsZSAobWFwc1tpXS5j b25zdW1lcl9kZXZfbmFtZSkgewo+IAoKVXBzLi4uIE5pY2UgY2F0Y2ghIEkgd2FzIHByb2JhYmx5 IGluIGJvdCBtb2RlIGFscmVhZHkuCgotIE51bm8gU8OhCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0Ckxp bnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4DCCC43334 for ; Thu, 16 Jun 2022 02:25:53 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LNmHh2J5nz3fCh for ; Thu, 16 Jun 2022 12:25:52 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=DTARzN9Z; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::635; helo=mail-ej1-x635.google.com; envelope-from=noname.nuno@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=DTARzN9Z; dkim-atps=neutral Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LKWmp1fsmz3btG for ; Sat, 11 Jun 2022 05:51:21 +1000 (AEST) Received: by mail-ej1-x635.google.com with SMTP id gl15so30943ejb.4 for ; Fri, 10 Jun 2022 12:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=bNY4bb5ZsDGbijlscX/zWHp76bvVhoKTJQjCK2gLBow=; b=DTARzN9ZKxLbpM5DnF604iI8/F/84/wIKw08CbQfw05YnVX88YGW6HVfBxQNHvMu4T MLrV3I1t6KM5Qc6HlnyeXHSTGoq8+8DaWtqoRUwsLbX6Mzc8EpX122ha3qRBRoFfEqzN Jk0f/3X9FLtgjhjaqJKanWVijWyNNRgDw6pmj5+2xfApIvc2SRAwOjLitceTonJ4eGE1 a1A9wbvVgJFRqD/0S50YXqjQh+yziCS7x5lzFW9SKapPD3uUc9it44OjhImJd8j2+oZt Butz14g0HcCbwqNDkTuGrH/EVS+NkDJB41ZnGmOfym00EegEpO7qNAqhl52gA+RezkJc GTxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bNY4bb5ZsDGbijlscX/zWHp76bvVhoKTJQjCK2gLBow=; b=WaYSZhWJeHpMRlML6msUHD/fGOSYjJMHQt0rN1eDhXSpKmx+X/CGVyEZ3rWgJFdgo5 WQGwVWfNpCsJsAIKvkdqccXKth/XMikKR4Vfkfk1vw7KNhElLJWzVYbIEoRc1oOO/zug bALoItyHYZhA1bQbixJ83XhIDTyEjZoz+F3tFSxxpsv9VT7c7Vk8ZIkTL+cQKAN4Sxjj 8qUe5fOLh3x2XHkUX7CexMnofh55FZG6qjEYuOsXC5DLE6BPyJr6Iw/D9n1POhvoLmS5 POxWryytUUtipbO+0mtmNNXtHkV4rSUagi2iMDOceRZrsx0HCThCmNx+a7jxiDfBuaty uEeg== X-Gm-Message-State: AOAM532lT+OUgkQYyLDMLcZfpHKumy2UmKWIxhhXMlLtC5nY4W1jS/bV 4+gG6WUbMCG/qizXkZiZvw0= X-Google-Smtp-Source: ABdhPJxHRykgXinV3uoaEPm9Ud4a9M4gnh2v3qf5U98udrI7NhTVLe93fDw1Gnx05NF5PsnFjGIIwQ== X-Received: by 2002:a17:906:51d6:b0:712:c9:8a1b with SMTP id v22-20020a17090651d600b0071200c98a1bmr10665567ejk.656.1654890677793; Fri, 10 Jun 2022 12:51:17 -0700 (PDT) Received: from ?IPv6:2001:a61:136e:3c01:8bd4:cf6f:76f1:a861? ([2001:a61:136e:3c01:8bd4:cf6f:76f1:a861]) by smtp.gmail.com with ESMTPSA id ck16-20020a170906c45000b006feb20b5235sm12715703ejb.84.2022.06.10.12.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 12:51:17 -0700 (PDT) Message-ID: Subject: Re: [PATCH 34/34] iio: inkern: fix coding style warnings From: Nuno =?ISO-8859-1?Q?S=E1?= To: Joe Simmons-Talbott , Nuno =?ISO-8859-1?Q?S=E1?= Date: Fri, 10 Jun 2022 21:51:15 +0200 In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-35-nuno.sa@analog.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 16 Jun 2022 12:05:36 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Daniel Lezcano , Tomer Maimon , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , Alexandre Torgue , Tali Perry , Paul Cercueil , Miquel Raynal , Guenter Roeck , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, chrome-platform@lists.linux.dev, Lars-Peter Clausen , Benjamin Fair , openbmc@lists.ozlabs.org, Jishnu Prakash , Haibo Chen , Andy Shevchenko , Andy Gross , linux-imx@nxp.com, Olivier Moysan , Zhang Rui , Christophe Branchereau , Saravanan Sekar , Michael Hennerich , linux-arm-msm@vger.kernel.org, Sascha Hauer , Nicolas Ferre , Lad Prabhakar , Fabrice Gasnier , linux-mediatek@lists.infradead.org, Eugen Hristev , Matthias Brugger , Gwendal Grignou , Bjorn Andersson , Benson Leung , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, Lorenzo Bianconi , Avi Fishman , Patrick Venture , linux-mips@vger.kernel.org, Thara Gopinath , linux-renesas-soc@vger.kernel.org, Arnd Bergmann , Maxime Coquelin , Cai Huoqing , Shawn Guo , Claudiu Beznea , Jonathan Cameron Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, 2022-06-10 at 11:53 -0400, Joe Simmons-Talbott wrote: > On Fri, Jun 10, 2022 at 10:45:45AM +0200, Nuno Sá wrote: > > Just cosmetics. No functional change intended... > > > > Signed-off-by: Nuno Sá > > --- > >  drivers/iio/inkern.c | 64 ++++++++++++++++++++++------------------ > > ---- > >  1 file changed, 32 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c > > index 7eb536560ded..526519cefcb9 100644 > > --- a/drivers/iio/inkern.c > > +++ b/drivers/iio/inkern.c > > @@ -45,13 +45,13 @@ int iio_map_array_register(struct iio_dev > > *indio_dev, struct iio_map *maps) > >         int i = 0, ret = 0; > >         struct iio_map_internal *mapi; > >   > > -       if (maps == NULL) > > +       if (!maps) > >                 return 0; > >   > >         mutex_lock(&iio_map_list_lock); > > -       while (maps[i].consumer_dev_name != NULL) { > > +       while (!maps[i].consumer_dev_name) { > > Shouldn't this be?: > while (maps[i].consumer_dev_name) { > Ups... Nice catch! I was probably in bot mode already. - Nuno Sá